editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java - Issue 64863002: Issue 14748. Name of type alias is a valid const expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java

Issue 64863002: Issue 14748. Name of type alias is a valid const expression. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java

diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java

index 0041338e025a26a3951fe80b8f4640354ed1141c..175a74470050d3eb87ee4cdf456bd6d28e092cb3 100644

--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java

+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/constant/ConstantVisitor.java

@@ -48,6 +48,7 @@ import com.google.dart.engine.element.ConstructorElement;

import com.google.dart.engine.element.Element;

import com.google.dart.engine.element.ExecutableElement;

import com.google.dart.engine.element.FunctionElement;

+import com.google.dart.engine.element.FunctionTypeAliasElement;

import com.google.dart.engine.element.LibraryElement;

import com.google.dart.engine.element.PrefixElement;

import com.google.dart.engine.element.PropertyAccessorElement;

@@ -401,7 +402,7 @@ public class ConstantVisitor extends UnifyingASTVisitor<EvaluationResultImpl> {

if (((ExecutableElement) element).isStatic()) {

return new ValidResult(element);

}

- } else if (element instanceof ClassElement) {

+ } else if (element instanceof ClassElement || element instanceof FunctionTypeAliasElement) {

return ValidResult.RESULT_OBJECT;

}

// TODO(brianwilkerson) Figure out which error to report.