chrome/test/data/push_messaging/test.html - Issue 648623003: PushMessagingBrowserTest for registration success and failure

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/push_messaging/test.html

Issue 648623003: PushMessagingBrowserTest for registration success and failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master

Patch Set: Rebase. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	Peter Beverloo 2014/10/20 12:45:22 Carry-forward since you did not reply. ===== nit Carry-forward since you did not reply. ===== nit: <!DOCTYPE html> Michael van Ouwerkerk 2014/10/20 15:30:37 Done. Show quoted text On 2014/10/20 12:45:22, Peter Beverloo wrote: > Carry-forward since you did not reply. > > ===== > > nit: <!DOCTYPE html> Done.
	2 <head>

	3 <title>Push API</title>
	Peter Beverloo 2014/10/20 12:45:22 Carry-forward since you did not reply. ===== mic Carry-forward since you did not reply. ===== micro nit: This is not the Push API, it's a test runner for the Push API. Dito with the page's body -- for people randomly coming across this file it might be nice to add a little bit (half a sentence) of explanation. Michael van Ouwerkerk 2014/10/20 15:30:37 It's a test, so I marked it as such now. Not sure Show quoted text On 2014/10/20 12:45:22, Peter Beverloo wrote: > Carry-forward since you did not reply. > > ===== > > micro nit: This is not the Push API, it's a test runner for the Push API. Dito > with the page's body -- for people randomly coming across this file it might be > nice to add a little bit (half a sentence) of explanation. It's a test, so I marked it as such now. Not sure what else you would like me to write in terms of explanation, it looks fine to me.
	4 <script>

	5 function sendResultToTest(result) {

	6 console.log(result);

	7 if (window.domAutomationController) {

	8 domAutomationController.send('' + result);

	9 }

	10 }

	11

	12 function sendErrorToTest(error) {

	13 sendResultToTest(error.name + ' - ' + error.message);

	14 }

	15

	16 function registerServiceWorker() {

	17 navigator.serviceWorker.register('sw.js').then(function(swRegistration) {

	18 console.log(swRegistration);

	19 sendResultToTest('ok');

	20 }, sendErrorToTest);

	21 }

	22

	23 function registerPush(senderId) {

	24 navigator.serviceWorker.ready.then(function() {

	25 navigator.push.register(senderId).then(function(pushRegistration) {

	26 sendResultToTest(pushRegistration.pushEndpoint + ' - ' + pushRegistrat ion.pushRegistrationId);

	27 }, sendErrorToTest);

	28 }, sendErrorToTest);

	29 }

	30 </script>

	31 </head>

	32 <body>Push API</body>

	33 </html>

OLD	NEW

« chrome/test/data/push_messaging/sw.js ('K') | « chrome/test/data/push_messaging/sw.js ('k') | net/tools/testserver/testserver.py » ('j') | no next file with comments »