Side by Side Diff: chrome/test/data/push_messaging/sw.js
Issue 648623003:
PushMessagingBrowserTest for registration success and failure (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Rebase.
Created 6 years, 2 months ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
Peter Beverloo
2014/10/20 12:45:22
Carry-forward since you did not reply to this. Ple
Carry-forward since you did not reply to this. Please carefully check if you
replied to all comments before asking a reviewer to take another look.
=====
Please name this file service_worker.js. (The initialism "SW" is a bit
overloaded.)
nit: Add a TODO to indicate that a "push" event listener has to be added here
for future tests?
On 2014/10/20 12:45:22, Peter Beverloo wrote:
> Carry-forward since you did not reply to this. Please carefully check if you
> replied to all comments before asking a reviewer to take another look.
>
> =====
>
> Please name this file service_worker.js. (The initialism "SW" is a bit
> overloaded.)
>
> nit: Add a TODO to indicate that a "push" event listener has to be added here
> for future tests?
Issue 648623003: PushMessagingBrowserTest for registration success and failure
(Closed)
Created 6 years, 2 months ago by Michael van Ouwerkerk
Modified 6 years, 1 month ago
Reviewers: Peter Beverloo, fgorski, Paweł Hajdan Jr.
Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Comments: 51