Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 648613007: Roll usrsctp -> r9045. (Closed)

Created:
6 years, 2 months ago by pbos
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll usrsctp -> r9045. Picks up various valgrind fixes, hopefully fixing MSan issues seen in standalone webrtc. R=ldixon@chromium.org R=lally@chromium.org BUG= Committed: https://crrev.com/de13cf44ff5aa5815dd742c2cedcaece02601f4b Cr-Commit-Position: refs/heads/master@{#299488}

Patch Set 1 #

Patch Set 2 : updated other buildfiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/usrsctp/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/usrsctp/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/usrsctp/usrsctp.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/usrsctp/usrsctp_nacl.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (9 generated)
pbos
PTAL + CQ if you agree. :)
6 years, 2 months ago (2014-10-13 15:08:34 UTC) #1
ldixon
On 2014/10/13 15:08:34, pbos wrote: > PTAL + CQ if you agree. :) LGTM. But ...
6 years, 2 months ago (2014-10-13 17:49:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648613007/1
6 years, 2 months ago (2014-10-13 21:16:50 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-13 21:17:01 UTC) #6
lally
lgtm
6 years, 2 months ago (2014-10-13 21:22:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648613007/1
6 years, 2 months ago (2014-10-13 21:23:37 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-13 21:23:40 UTC) #12
pbos
+tommi, we need a superstar committer :)
6 years, 2 months ago (2014-10-13 21:29:45 UTC) #14
tommi (sloooow) - chröme
lgtm
6 years, 2 months ago (2014-10-14 13:30:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648613007/1
6 years, 2 months ago (2014-10-14 13:32:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/7643)
6 years, 2 months ago (2014-10-14 13:39:38 UTC) #19
pbos
On 2014/10/14 13:39:38, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-14 14:08:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648613007/190001
6 years, 2 months ago (2014-10-14 14:09:10 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:190001)
6 years, 2 months ago (2014-10-14 15:15:29 UTC) #23
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 15:16:12 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de13cf44ff5aa5815dd742c2cedcaece02601f4b
Cr-Commit-Position: refs/heads/master@{#299488}

Powered by Google App Engine
This is Rietveld 408576698