Implement bigint absAdd, absSub, mulAdd, sqrAdd, estQuotientDigit intrinsics,

runtime/vm/assembler_x64.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_X64_H_
 #define VM_ASSEMBLER_X64_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_x64.h directly; use assembler.h instead.
 #endif
@@ skipping 528 matching lines @@
   void orq(Register dst, const Immediate& imm);
   void OrImmediate(Register dst, const Immediate& imm, Register pp);
 
   void xorq(Register dst, Register src);
   void xorq(Register dst, const Address& address);
   void xorq(const Address& dst, Register src);
   void xorq(Register dst, const Immediate& imm);
   void XorImmediate(Register dst, const Immediate& imm, Register pp);
 
   void addl(Register dst, Register src);
-  void addl(const Address& address, const Immediate& imm);
+  void addl(Register dst, const Address& address);

[zra, 2014/10/10 16:23:43]

Please add assembler tests for addl, adcl, subl, and sbbl.

[regis, 2014/10/10 19:15:47]

Done.

+  void addl(const Address& address, Register src);
+  void adcl(Register dst, Register src);
+  void adcl(Register dst, const Immediate& imm);
+  void adcl(Register dst, const Address& address);
 
   void addq(Register dst, Register src);
-  void addq(Register reg, const Immediate& imm);
-  void addq(Register reg, const Address& address);
+  void addq(Register dst, const Immediate& imm);
+  void addq(Register dst, const Address& address);
   void addq(const Address& address, const Immediate& imm);
-  void addq(const Address& address, Register reg);
-
-  void adcl(Register dst, Register src);
-
-  void subl(Register dst, Register src);
+  void addq(const Address& address, Register src);
 
   void cdq();
   void cqo();
 
   void idivl(Register reg);
+  void divl(Register reg);
+
   void idivq(Register reg);
 
   void imull(Register dst, Register src);
   void imull(Register reg, const Immediate& imm);
+  void mull(Register reg);
 
   void imulq(Register dst, Register src);
   void imulq(Register dst, const Address& address);
   void imulq(Register dst, const Immediate& imm);
   void MulImmediate(Register reg, const Immediate& imm, Register pp);
 
+  void subl(Register dst, Register src);
+  void sbbl(Register dst, const Immediate& imm);
+  void sbbl(Register dst, const Address& address);
+
   void subq(Register dst, Register src);
   void subq(Register reg, const Immediate& imm);
   void subq(Register reg, const Address& address);
   void subq(const Address& address, Register reg);
   void subq(const Address& address, const Immediate& imm);
 
   void shll(Register reg, const Immediate& imm);
   void shll(Register operand, Register shifter);
   void shrl(Register reg, const Immediate& imm);
   void shrl(Register operand, Register shifter);
   void sarl(Register reg, const Immediate& imm);
   void sarl(Register operand, Register shifter);
+  void shldl(Register dst, Register src, const Immediate& imm);
 
   void shlq(Register reg, const Immediate& imm);
   void shlq(Register operand, Register shifter);
   void shrq(Register reg, const Immediate& imm);
   void shrq(Register operand, Register shifter);
   void sarq(Register reg, const Immediate& imm);
   void sarq(Register operand, Register shifter);
 
   void incl(const Address& address);
   void decl(const Address& address);
@@ skipping 429 matching lines @@
                          Patchability patchable,
                          Register pp);
   bool CanLoadFromObjectPool(const Object& object);
   void LoadWordFromPoolOffset(Register dst, Register pp, int32_t offset);
 
   inline void EmitUint8(uint8_t value);
   inline void EmitInt32(int32_t value);
   inline void EmitInt64(int64_t value);
 
   inline void EmitRegisterREX(Register reg, uint8_t rex);
-  inline void EmitRegisterOperand(int rm, int reg);
   inline void EmitOperandREX(int rm, const Operand& operand, uint8_t rex);
   inline void EmitXmmRegisterOperand(int rm, XmmRegister reg);
   inline void EmitFixup(AssemblerFixup* fixup);
   inline void EmitOperandSizeOverride();
   inline void EmitREX_RB(XmmRegister reg,
                          XmmRegister base,
                          uint8_t rex = REX_NONE);
   inline void EmitREX_RB(XmmRegister reg,
                          const Operand& operand,
                          uint8_t rex = REX_NONE);
@@ skipping 100 matching lines @@
 }
 
 
 inline void Assembler::EmitOperandSizeOverride() {
   EmitUint8(0x66);
 }
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_X64_H_