Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 648573002: remove websocket server dependency from the mojo spy (Closed)

Created:
6 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove websocket server dependency from the mojo spy So the core of the mojo spy can travel to new, exciting destinations. BUG=none Committed: https://crrev.com/0b077e3f05e33234056f0eb1b30868e690e7d8c9 Cr-Commit-Position: refs/heads/master@{#299036}

Patch Set 1 #

Patch Set 2 : small cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -34 lines) Patch
M mojo/shell/context.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/spy/spy.h View 1 3 chunks +21 lines, -0 lines 0 comments Download
M mojo/spy/spy.cc View 10 chunks +45 lines, -34 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
cpu_(ooo_6.6-7.5)
6 years, 2 months ago (2014-10-09 23:02:18 UTC) #2
jamesr
lgtm thanks
6 years, 2 months ago (2014-10-09 23:07:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648573002/180001
6 years, 2 months ago (2014-10-10 00:27:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:180001)
6 years, 2 months ago (2014-10-10 01:57:04 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 02:05:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0b077e3f05e33234056f0eb1b30868e690e7d8c9
Cr-Commit-Position: refs/heads/master@{#299036}

Powered by Google App Engine
This is Rietveld 408576698