Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648563003: Fix webtry setup once instructions in README doc. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
humper
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix webtry setup once instructions in README doc. BUG=None TEST=NOne R=humper@google.com TBR=humper@google.com Committed: https://skia.googlesource.com/skia/+/5d0706ffd3a66ec18dfc8ebea60ef28778a8455d

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M experimental/webtry/README.md View 3 chunks +3 lines, -8 lines 1 comment Download

Messages

Total messages: 15 (5 generated)
tfarina
PTAL. https://codereview.chromium.org/648563003/diff/1/experimental/webtry/README.md File experimental/webtry/README.md (left): https://codereview.chromium.org/648563003/diff/1/experimental/webtry/README.md#oldcode67 experimental/webtry/README.md:67: 4. git clone https://skia.googlesource.com/skia this is repeating lines ...
6 years, 2 months ago (2014-10-10 02:35:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648563003/1
6 years, 2 months ago (2014-10-10 12:42:50 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 12:42:51 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-10 18:42:50 UTC) #6
tfarina
TBRing Greg. He approved by email, but unfortunately email messages to the group do not ...
6 years, 2 months ago (2014-10-13 14:14:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648563003/1
6 years, 2 months ago (2014-10-13 14:14:36 UTC) #9
humper
On 2014/10/13 14:14:36, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-10-13 15:01:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/9)
6 years, 2 months ago (2014-10-13 15:04:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648563003/1
6 years, 2 months ago (2014-10-13 15:08:00 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:37:56 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 5d0706ffd3a66ec18dfc8ebea60ef28778a8455d

Powered by Google App Engine
This is Rietveld 408576698