Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648563002: Revitalize (and move) a block comment about how cross-process navigation works. (Closed)

Created:
6 years, 2 months ago by ncarter (slow)
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@is_rfh_swapped
Project:
chromium
Visibility:
Public.

Description

Revitalize (and move) a block comment about how cross-process navigation works. BUG=304341 TEST=comment-only CL Committed: https://crrev.com/bca18a079baf543061eb9023718792bbf59a95de Cr-Commit-Position: refs/heads/master@{#299337}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -53 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 1 chunk +47 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ncarter (slow)
6 years, 2 months ago (2014-10-09 22:50:58 UTC) #2
ncarter (slow)
Charlie, please review (we paired on this)
6 years, 2 months ago (2014-10-09 22:51:57 UTC) #3
Charlie Reis
Thanks for updating this! LGTM with nit. https://codereview.chromium.org/648563002/diff/1/content/browser/frame_host/render_frame_host_manager.h File content/browser/frame_host/render_frame_host_manager.h (right): https://codereview.chromium.org/648563002/diff/1/content/browser/frame_host/render_frame_host_manager.h#newcode67 content/browser/frame_host/render_frame_host_manager.h:67: // main ...
6 years, 2 months ago (2014-10-10 16:20:40 UTC) #4
ncarter (slow)
https://codereview.chromium.org/648563002/diff/1/content/browser/frame_host/render_frame_host_manager.h File content/browser/frame_host/render_frame_host_manager.h (right): https://codereview.chromium.org/648563002/diff/1/content/browser/frame_host/render_frame_host_manager.h#newcode67 content/browser/frame_host/render_frame_host_manager.h:67: // main resource load on the pending RFH. It ...
6 years, 2 months ago (2014-10-13 17:41:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648563002/90001
6 years, 2 months ago (2014-10-13 17:43:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:90001)
6 years, 2 months ago (2014-10-13 19:01:45 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:02:43 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bca18a079baf543061eb9023718792bbf59a95de
Cr-Commit-Position: refs/heads/master@{#299337}

Powered by Google App Engine
This is Rietveld 408576698