Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: net/base/chunked_upload_data_stream.h

Issue 648543005: Replace newly added OVERRIDE with its C++11 counterparts in src/net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/base/elements_upload_data_stream.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_BASE_CHUNKED_UPLOAD_DATA_STREAM_H_ 5 #ifndef NET_BASE_CHUNKED_UPLOAD_DATA_STREAM_H_
6 #define NET_BASE_CHUNKED_UPLOAD_DATA_STREAM_H_ 6 #define NET_BASE_CHUNKED_UPLOAD_DATA_STREAM_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 17 matching lines...) Expand all
28 virtual ~ChunkedUploadDataStream(); 28 virtual ~ChunkedUploadDataStream();
29 29
30 // Adds data to the stream. |is_done| should be true if this is the last 30 // Adds data to the stream. |is_done| should be true if this is the last
31 // data to be appended. |data_len| must not be 0 unless |is_done| is true. 31 // data to be appended. |data_len| must not be 0 unless |is_done| is true.
32 // Once called with |is_done| being true, must never be called again. 32 // Once called with |is_done| being true, must never be called again.
33 // TODO(mmenke): Consider using IOBuffers instead, to reduce data copies. 33 // TODO(mmenke): Consider using IOBuffers instead, to reduce data copies.
34 void AppendData(const char* data, int data_len, bool is_done); 34 void AppendData(const char* data, int data_len, bool is_done);
35 35
36 private: 36 private:
37 // UploadDataStream implementation. 37 // UploadDataStream implementation.
38 virtual int InitInternal() OVERRIDE; 38 virtual int InitInternal() override;
39 virtual int ReadInternal(IOBuffer* buf, int buf_len) OVERRIDE; 39 virtual int ReadInternal(IOBuffer* buf, int buf_len) override;
40 virtual void ResetInternal() OVERRIDE; 40 virtual void ResetInternal() override;
41 41
42 int ReadChunk(IOBuffer* buf, int buf_len); 42 int ReadChunk(IOBuffer* buf, int buf_len);
43 43
44 // Index and offset of next element of |upload_data_| to be read. 44 // Index and offset of next element of |upload_data_| to be read.
45 size_t read_index_; 45 size_t read_index_;
46 size_t read_offset_; 46 size_t read_offset_;
47 47
48 // True once all data has been appended to the stream. 48 // True once all data has been appended to the stream.
49 bool all_data_appended_; 49 bool all_data_appended_;
50 50
51 ScopedVector<std::vector<char>> upload_data_; 51 ScopedVector<std::vector<char>> upload_data_;
52 52
53 // Buffer to write the next read's data to. Only set when a call to 53 // Buffer to write the next read's data to. Only set when a call to
54 // ReadInternal reads no data. 54 // ReadInternal reads no data.
55 scoped_refptr<IOBuffer> read_buffer_; 55 scoped_refptr<IOBuffer> read_buffer_;
56 int read_buffer_len_; 56 int read_buffer_len_;
57 57
58 DISALLOW_COPY_AND_ASSIGN(ChunkedUploadDataStream); 58 DISALLOW_COPY_AND_ASSIGN(ChunkedUploadDataStream);
59 }; 59 };
60 60
61 } // namespace net 61 } // namespace net
62 62
63 #endif // NET_BASE_CHUNKED_UPLOAD_DATA_STREAM_H_ 63 #endif // NET_BASE_CHUNKED_UPLOAD_DATA_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | net/base/elements_upload_data_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698