Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 64853004: Use high resolution icons where possible for streamlined hosted app icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_experiment_create_app_from_page
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 2884c46819f402a25a295470c55017ece695dc09..1029c74632cacf7e61d63f1add3dd3a7753c749c 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -176,6 +176,9 @@ const char* const kBrowserViewKey = "__BROWSER_VIEW__";
// The number of milliseconds between loading animation frames.
const int kLoadingAnimationFrameTimeMs = 30;
+// The size of the window icon in pixels.
tapted 2013/11/11 08:52:57 Are these device-independent pixels? (ImageFamily
calamity 2013/11/13 06:37:14 Removed.
+const int kWindowIconSize = 32;
tapted 2013/11/11 08:52:57 I wonder if this should be IconUtil::kMediumIconSi
calamity 2013/11/13 06:37:14 Done.
+
// TODO(kuan): These functions are temporarily for the bookmark bar while its
// detached state is at the top of the page; it'll be moved to float on the
// content page in the very near future, at which time, these local functions
@@ -1567,7 +1570,7 @@ gfx::ImageSkia BrowserView::GetWindowAppIcon() {
gfx::ImageSkia BrowserView::GetWindowIcon() {
if (browser_->is_app() || browser_->is_type_popup())
- return browser_->GetCurrentPageIcon().AsImageSkia();
+ return browser_->GetCurrentPageIcon(kWindowIconSize).AsImageSkia();
tapted 2013/11/11 08:52:57 Looks like c/b/ui/gtk/browser_titlebar.cc might us
calamity 2013/11/13 06:37:14 Fixed it just in case.
return gfx::ImageSkia();
}

Powered by Google App Engine
This is Rietveld 408576698