Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: chrome/browser/extensions/tab_helper.h

Issue 64853004: Use high resolution icons where possible for streamlined hosted app icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_experiment_create_app_from_page
Patch Set: fix tests for linux Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/favicon_downloader_unittest.cc ('k') | chrome/browser/extensions/tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/tab_helper.h
diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h
index e41a10c8dfd3744b666cd2eb7ebc01b3727d4e39..0905d71f949584cdb3dd57a1954bd9d792a7bcf2 100644
--- a/chrome/browser/extensions/tab_helper.h
+++ b/chrome/browser/extensions/tab_helper.h
@@ -23,6 +23,8 @@
#include "extensions/common/stack_frame.h"
#include "third_party/skia/include/core/SkBitmap.h"
+class FaviconDownloader;
+
namespace content {
struct LoadCommittedDetails;
}
@@ -99,8 +101,6 @@ class TabHelper : public content::WebContentsObserver,
void CreateHostedAppFromWebContents();
bool CanCreateApplicationShortcuts() const;
- void CreateHostedApp(const WebApplicationInfo& info);
-
void set_pending_web_app_action(WebAppAction action) {
pending_web_app_action_ = action;
}
@@ -170,6 +170,12 @@ class TabHelper : public content::WebContentsObserver,
explicit TabHelper(content::WebContents* web_contents);
friend class content::WebContentsUserData<TabHelper>;
+ // Creates a hosted app for the current tab. Requires the |web_app_info_| to
+ // be populated.
+ void CreateHostedApp();
+ void FinishCreateHostedApp(
+ bool success, const std::map<GURL, std::vector<SkBitmap> >& bitmaps);
+
// content::WebContentsObserver overrides.
virtual void RenderViewCreated(
content::RenderViewHost* render_view_host) OVERRIDE;
@@ -269,6 +275,8 @@ class TabHelper : public content::WebContentsObserver,
scoped_ptr<ScriptBubbleController> script_bubble_controller_;
+ scoped_ptr<FaviconDownloader> favicon_downloader_;
+
Profile* profile_;
// Vend weak pointers that can be invalidated to stop in-progress loads.
« no previous file with comments | « chrome/browser/extensions/favicon_downloader_unittest.cc ('k') | chrome/browser/extensions/tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698