Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 64853004: Use high resolution icons where possible for streamlined hosted app icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_experiment_create_app_from_page
Patch Set: add RenderViewImpl test to ensure FaviconTabHelper is not sent an empty vector Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_tab_helper.h
diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h
index b8255a66b848523b23d9081049e42006b97989ce..983f58cccbad6c2ed5c94a1a86ea5b226367e387 100644
--- a/chrome/browser/favicon/favicon_tab_helper.h
+++ b/chrome/browser/favicon/favicon_tab_helper.h
@@ -51,6 +51,12 @@ class FaviconTabHelper : public content::WebContentsObserver,
// space is provided for the favicon, and the favicon is never displayed.
virtual bool ShouldDisplayFavicon();
+ // Returns the current tab's favicon urls. Returns NULL if the current tab's
+ // favicon urls have not been populated yet.
+ const std::vector<content::FaviconURL>& favicon_urls() const {
+ return favicon_urls_;
+ }
+
// Allows the client to determine if they want to fetch the Favicons as
// they are discovered.
void set_should_fetch_icons(bool fetch) {
@@ -94,6 +100,8 @@ class FaviconTabHelper : public content::WebContentsObserver,
Profile* profile_;
bool should_fetch_icons_;
+ std::vector<content::FaviconURL> favicon_urls_;
+
scoped_ptr<FaviconHandler> favicon_handler_;
// Handles downloading touchicons. It is NULL if

Powered by Google App Engine
This is Rietveld 408576698