Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.h

Issue 64853004: Use high resolution icons where possible for streamlined hosted app icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_experiment_create_app_from_page
Patch Set: rework Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_downloader_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.h
diff --git a/chrome/browser/favicon/favicon_tab_helper.h b/chrome/browser/favicon/favicon_tab_helper.h
index a5ef1ae2fd1f198a738976d08623f37a9145372a..72845b8544c013fa5f473207ccb3aba6e7e0e77a 100644
--- a/chrome/browser/favicon/favicon_tab_helper.h
+++ b/chrome/browser/favicon/favicon_tab_helper.h
@@ -51,6 +51,12 @@ class FaviconTabHelper : public content::WebContentsObserver,
// space is provided for the favicon, and the favicon is never displayed.
virtual bool ShouldDisplayFavicon();
+ // Returns the current tab's favicon urls. Returns NULL if the current tab's
pkotwicz 2013/12/04 05:48:18 Nit: This comment needs to be updated
calamity 2013/12/05 02:42:57 Done.
+ // favicon urls have not been populated yet.
+ const std::vector<content::FaviconURL>& GetFaviconURLs() {
sky 2013/12/04 16:05:24 Name this favicon_urls, and make it a const method
calamity 2013/12/05 02:42:57 Done.
+ return favicon_urls_;
+ }
+
// Allows the client to determine if they want to fetch the Favicons as
// they are discovered.
void set_should_fetch_icons(bool fetch) {
@@ -94,6 +100,8 @@ class FaviconTabHelper : public content::WebContentsObserver,
Profile* profile_;
bool should_fetch_icons_;
+ std::vector<content::FaviconURL> favicon_urls_;
+
scoped_ptr<FaviconHandler> favicon_handler_;
// Handles downloading touchicons. It is NULL if
« no previous file with comments | « chrome/browser/favicon/favicon_downloader_unittest.cc ('k') | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698