Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 648483004: Document that philipj/fs review <track>, WebVTT, etc. (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 2 months ago
Reviewers:
pdr., Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, abarth-chromium, dglazkov+blink, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Document that philipj/fs review <track>, WebVTT, etc. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183543

Patch Set 1 #

Patch Set 2 : fs for president #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/core/html/track/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
PTAL, I hope this is what you had in mind.
6 years, 2 months ago (2014-10-10 13:30:45 UTC) #2
philipj_slow
fs for president
6 years, 2 months ago (2014-10-10 13:35:12 UTC) #3
philipj_slow
Added fs for track/ as well, I think he'll have a separate CL annotating his ...
6 years, 2 months ago (2014-10-10 13:38:33 UTC) #4
Mike West
LGTM, though I think it's safe to TBR this to yourself. :)
6 years, 2 months ago (2014-10-10 13:55:17 UTC) #6
philipj_slow
On 2014/10/10 13:55:17, Mike West wrote: > LGTM, though I think it's safe to TBR ...
6 years, 2 months ago (2014-10-10 14:07:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648483004/60001
6 years, 2 months ago (2014-10-10 14:08:22 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 14:09:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as 183543

Powered by Google App Engine
This is Rietveld 408576698