Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 648463004: Ensure that the page id assignment IPC is sent. (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)
Modified:
6 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ensure that the page id assignment IPC is sent. If it's failing to be sent, this would explain some of the cases of the bug. BUG=407376 TEST=no change Committed: https://crrev.com/f5125a284eaf0a42834bc6bd773ed38a2bfcc270 Cr-Commit-Position: refs/heads/master@{#300158}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Avi (use Gerrit)
6 years, 2 months ago (2014-10-16 19:59:01 UTC) #2
Charlie Reis
Yep, let's give it a try. LGTM.
6 years, 2 months ago (2014-10-16 20:12:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648463004/1
6 years, 2 months ago (2014-10-17 19:55:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 20:47:25 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 20:48:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5125a284eaf0a42834bc6bd773ed38a2bfcc270
Cr-Commit-Position: refs/heads/master@{#300158}

Powered by Google App Engine
This is Rietveld 408576698