Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 648443002: Revert of Catch uncaught promise rejections from V8 and log to console. (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert of Catch uncaught promise rejections from V8 and log to console. (patchset #10 id:180001 of https://codereview.chromium.org/625943002/) Reason for revert: Broke extensions_unittests.ModuleSystemTest.TestRequireAsyncFromContextWithNoModuleRegistry and UtilsUnittest.PromiseError at least. See http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=extensions_unittests&tests=ModuleSystemTest.TestRequireAsyncFromContextWithNoModuleRegistry%2C%20UtilsUnittest.PromiseError Original issue's description: > Catch uncaught promise rejections from V8 and log to console. > > Print error messages to DevTools console for rejected Promises that are unhandled by the platform end-of-turn. > > BUG=393913 > R=pfeldman, yurys > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183464 TBR=pfeldman@chromium.org,yurys@chromium.org,jl@opera.com,aandrey@chromium.org NOTREECHECKS=true NOTRY=true BUG=393913 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -288 lines) Patch
M LayoutTests/fast/css/fontfaceset-multiple-faces-download-error.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/fontfaceset-multiple-families.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/console-test.js View 4 chunks +8 lines, -22 lines 0 comments Download
M LayoutTests/inspector/console/console-format-es6.html View 1 chunk +1 line, -4 lines 0 comments Download
D LayoutTests/inspector/console/console-uncaught-promise.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/inspector/console/console-uncaught-promise-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause.html View 1 chunk +0 lines, -83 lines 0 comments Download
D LayoutTests/inspector/sources/debugger/debugger-uncaught-promise-on-pause-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M LayoutTests/inspector/sources/debugger/event-listener-breakpoints-promises.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Initializer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 4 chunks +0 lines, -64 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
apavlov
Created Revert of Catch uncaught promise rejections from V8 and log to console.
6 years, 2 months ago (2014-10-09 15:10:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648443002/1
6 years, 2 months ago (2014-10-09 15:14:33 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 15:15:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183469

Powered by Google App Engine
This is Rietveld 408576698