Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 64843004: Get rid of user-level styles. (Closed)

Created:
7 years, 1 month ago by ojan
Modified:
7 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Get rid of user-level styles. -The Apps codepath for this is just using the wrong thing. It should be using author-level styles like extensions do. -The user-stylesheet feature requires the user to put a CSS stylesheet in the right location in their user-data-dir. Extensions are a much better way of doing this. This is in preparation for simplifying the Blink style resolution code by removing the concept of user styles. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234007

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -488 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 2 chunks +0 lines, -11 lines 0 comments Download
D chrome/browser/user_style_sheet_watcher.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/user_style_sheet_watcher.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D chrome/browser/user_style_sheet_watcher_factory.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/user_style_sheet_watcher_factory.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/user_style_sheet_watcher_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/dispatcher.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/web_preferences.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/common/webkit_test_helpers.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/common/webpreferences.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/common/webpreferences.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ojan
Darin, you mind reviewing this? You're the only one in all the required OWNERS files.
7 years, 1 month ago (2013-11-08 00:24:04 UTC) #1
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-08 00:55:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/64843004/1
7 years, 1 month ago (2013-11-08 01:07:25 UTC) #3
commit-bot: I haz the power
Failed to apply patch for content/public/common/common_param_traits_macros.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-08 09:56:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/64843004/290001
7 years, 1 month ago (2013-11-08 18:23:52 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 21:52:58 UTC) #6
Message was sent while issue was closed. 
Change committed as 234007

Powered by Google App Engine
This is Rietveld 408576698