Enforce ScriptForbiddenScope and make it non-fatal.

Source/bindings/core/v8/V8RecursionScope.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 44 matching lines @@
 // V8RecursionScope::MicrotaskSuppression -- this skips work that is spec'd to
 // happen at the end of the outer-most script stack frame of calls into page script:
 //
 // http://www.whatwg.org/specs/web-apps/current-work/#perform-a-microtask-checkpoint
 class V8RecursionScope {
     WTF_MAKE_NONCOPYABLE(V8RecursionScope);
 public:
     explicit V8RecursionScope(v8::Isolate* isolate)
         : m_isolate(isolate)
     {
+        RELEASE_ASSERT(!ScriptForbiddenScope::isScriptForbidden());
         V8PerIsolateData::from(m_isolate)->incrementRecursionLevel();
-        RELEASE_ASSERT(!ScriptForbiddenScope::isScriptForbidden());
         // If you want V8 to autorun microtasks, this class needs to have a
         // v8::Isolate::SuppressMicrotaskExecutionScope member.
         ASSERT(!isolate->WillAutorunMicrotasks());
     }
 
     ~V8RecursionScope()
     {
         if (!V8PerIsolateData::from(m_isolate)->decrementRecursionLevel())
             didLeaveScriptContext();
     }
@@ skipping 10 matching lines @@
     }
 #endif
 
     class MicrotaskSuppression {
     public:
         MicrotaskSuppression(v8::Isolate* isolate)
 #if ENABLE(ASSERT)
             : m_isolate(isolate)
 #endif
         {
             ASSERT(!ScriptForbiddenScope::isScriptForbidden());

[haraken, 2014/10/14 01:09:17]

Can we try to make this RELEASE_ASSERT in a follow-up CL?

[dcheng, 2014/10/14 05:47:30]

I think it makes sense to try this, but I would like to separate it into a
separate patch, since I don't know how tricky it will be to land this patch.

 #if ENABLE(ASSERT)
             V8PerIsolateData::from(m_isolate)->incrementInternalScriptRecursionLevel();
 #endif
         }
 
         ~MicrotaskSuppression()
         {
 #if ENABLE(ASSERT)
             V8PerIsolateData::from(m_isolate)->decrementInternalScriptRecursionLevel();
 #endif
         }
 
     private:
 #if ENABLE(ASSERT)
         v8::Isolate* m_isolate;
 #endif
     };
 
 private:
     void didLeaveScriptContext();
 
     v8::Isolate* m_isolate;
 };
 
 } // namespace blink
 
 #endif // V8RecursionScope_h