Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 648423002: Move painting code from FrameView to FramePainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Move painting code from FrameView to FramePainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183709

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Fixed. #

Patch Set 4 : Fixed debug build. #

Total comments: 6

Patch Set 5 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -240 lines) Patch
M Source/core/core.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 10 chunks +13 lines, -20 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 4 12 chunks +10 lines, -219 lines 0 comments Download
A Source/core/paint/FramePainter.h View 1 chunk +36 lines, -0 lines 0 comments Download
A Source/core/paint/FramePainter.cpp View 1 2 3 4 1 chunk +225 lines, -0 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
chrishtr
6 years, 2 months ago (2014-10-13 23:48:43 UTC) #2
chrishtr
ping?
6 years, 2 months ago (2014-10-14 20:04:46 UTC) #3
leviw_travelin_and_unemployed
lgtm. https://codereview.chromium.org/648423002/diff/160001/Source/core/frame/FrameView.h File Source/core/frame/FrameView.h (right): https://codereview.chromium.org/648423002/diff/160001/Source/core/frame/FrameView.h#newcode514 Source/core/frame/FrameView.h:514: // Widget override. Handles painting of the contents ...
6 years, 2 months ago (2014-10-14 22:06:11 UTC) #4
chrishtr
https://codereview.chromium.org/648423002/diff/160001/Source/core/frame/FrameView.h File Source/core/frame/FrameView.h (right): https://codereview.chromium.org/648423002/diff/160001/Source/core/frame/FrameView.h#newcode514 Source/core/frame/FrameView.h:514: // Widget override. Handles painting of the contents of ...
6 years, 2 months ago (2014-10-14 22:11:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648423002/180001
6 years, 2 months ago (2014-10-14 22:12:48 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 00:31:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:180001) as 183709

Powered by Google App Engine
This is Rietveld 408576698