Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2671)

Unified Diff: master/skia_master_scripts/recreate_skps_factory.py

Issue 648353002: Remove Skia's forked buildbot code (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Address comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « master/skia_master_scripts/nacl_factory.py ('k') | master/skia_master_scripts/skia_build_step.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: master/skia_master_scripts/recreate_skps_factory.py
diff --git a/master/skia_master_scripts/recreate_skps_factory.py b/master/skia_master_scripts/recreate_skps_factory.py
deleted file mode 100644
index df18a43d4a86bca4f3bd5a62316e6fad8ea8d1bb..0000000000000000000000000000000000000000
--- a/master/skia_master_scripts/recreate_skps_factory.py
+++ /dev/null
@@ -1,68 +0,0 @@
-# Copyright (c) 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""BuildFactory for a builder which recaptures the buildbot SKP repo."""
-
-
-from buildbot.process.properties import WithProperties
-from skia_master_scripts import canary_factory
-
-import builder_name_schema
-
-
-class RecreateSKPsFactory(canary_factory.CanaryFactory):
- """Subclass of CanaryFactory which builds Chrome with LKGR Skia, builds Skia
- tools and then runs the webpages_playback.py scripts to recreate all buildbot
- SKPs."""
-
- def __init__(self, **kwargs):
- """Initialize the RecreateSKPsFactory."""
- canary_factory.CanaryFactory.__init__(self,
- path_to_skia=['third_party', 'skia'],
- flavor='chrome',
- build_subdir='src',
- build_targets=['chrome'],
- **kwargs)
-
- def Build(self, role=builder_name_schema.BUILDER_ROLE_HOUSEKEEPER,
- clobber=None):
- """Build and return the complete BuildFactory.
-
- role: string; type of builder
- clobber: boolean; indicating whether we should clean before building
- """
- if role != builder_name_schema.BUILDER_ROLE_HOUSEKEEPER:
- raise Exception('Canary builders must have role "%s"' %
- builder_name_schema.BUILDER_ROLE_HOUSEKEEPER)
-
- # Build Chromium LKGR + Skia ToT.
- self.UpdateSteps()
- self.Compile(retry_without_werr_on_failure=True)
-
- # Invoke the do_skps_capture buildstep.
- skia_slave_scripts_path = self.TargetPath.join(
- '..', '..', '..', '..', '..', '..', 'slave',
- 'skia_slave_scripts')
- self.AddSlaveScript(
- script=self.TargetPath.join(skia_slave_scripts_path,
- 'do_skps_capture.py'),
- description='RecreateSKPs',
- args=['--page_sets', 'all',
- '--browser_executable', self.TargetPath.join(
- 'out', 'Debug', 'chrome')],
- timeout=None,
- halt_on_failure=True,
- workdir=self._workdir,
- get_props_from_stdout={'skp_version': r'SKP_VERSION=(\d+)'})
-
- self.AddSlaveScript(
- script=self.TargetPath.join(skia_slave_scripts_path,
- 'update_skp_version.py'),
- description='UpdateSkpVersion',
- workdir=self._workdir,
- args=['--skp_version', WithProperties('%(skp_version)s')]
- )
-
- self.Validate() # Run the factory configuration test.
- return self
« no previous file with comments | « master/skia_master_scripts/nacl_factory.py ('k') | master/skia_master_scripts/skia_build_step.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698