Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py

Issue 648353002: Remove Skia's forked buildbot code (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Address comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
diff --git a/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py b/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
deleted file mode 100644
index a76aae188564ae8f6099a5de5dd7f199b05b089d..0000000000000000000000000000000000000000
--- a/slave/skia_slave_scripts/flavor_utils/valgrind_build_step_utils.py
+++ /dev/null
@@ -1,41 +0,0 @@
-# Copyright (c) 2013 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-""" Utilities for Valgrind build steps. """
-
-from default_build_step_utils import DefaultBuildStepUtils
-from py.utils import shell_utils
-
-import os
-
-
-class ValgrindBuildStepUtils(DefaultBuildStepUtils):
- def __init__(self, build_step_instance):
- DefaultBuildStepUtils.__init__(self, build_step_instance)
- self._suppressions_file = os.path.join('tools', 'valgrind.supp')
-
- def RunFlavoredCmd(self, app, args):
- """ Override this in new BuildStep flavors. """
- cmd = ['valgrind', '--gen-suppressions=all', '--leak-check=no',
- '--track-origins=yes', '--error-exitcode=1']
- if self._suppressions_file:
- cmd.append('--suppressions=%s' % self._suppressions_file)
-
- cmd.append(self._PathToBinary(app))
- cmd.extend(args)
- return shell_utils.run(cmd)
-
- def Compile(self, target):
- os.environ['GYP_DEFINES'] = self._step.args['gyp_defines']
- print 'GYP_DEFINES="%s"' % os.environ['GYP_DEFINES']
- make_cmd = 'make'
- if os.name == 'nt':
- make_cmd = 'make.bat'
- cmd = [make_cmd,
- target,
- 'BUILDTYPE=%s' % self._step.configuration,
- ]
- cmd.extend(self._step.default_make_flags)
- cmd.extend(self._step.make_flags)
- shell_utils.run(cmd)

Powered by Google App Engine
This is Rietveld 408576698