Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: master/skia_master_scripts/housekeeping_periodic_factory.py

Issue 648353002: Remove Skia's forked buildbot code (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Address comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: master/skia_master_scripts/housekeeping_periodic_factory.py
diff --git a/master/skia_master_scripts/housekeeping_periodic_factory.py b/master/skia_master_scripts/housekeeping_periodic_factory.py
deleted file mode 100644
index d3bfac2d4825e4bcec80d1a44ee8680f2760dfcb..0000000000000000000000000000000000000000
--- a/master/skia_master_scripts/housekeeping_periodic_factory.py
+++ /dev/null
@@ -1,62 +0,0 @@
-# Copyright (c) 2012 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Utility class to build the Skia master BuildFactory's for HouseKeeping bots.
-
-Overrides SkiaFactory with Periodic HouseKeeping steps."""
-
-import builder_name_schema
-
-from config_private import SKIA_PUBLIC_MASTER_INTERNAL_FQDN
-from skia_master_scripts import factory as skia_factory
-
-
-# TODO: The HouseKeepingPeriodicFactory uses shell scripts, so it would break on
-# Windows. For now, we reply on the fact that the housekeeping bot always runs
-# on a Linux machine.
-class HouseKeepingPeriodicFactory(skia_factory.SkiaFactory):
- """Overrides for HouseKeeping periodic builds."""
-
- def Build(self, role=builder_name_schema.BUILDER_ROLE_HOUSEKEEPER,
- clobber=None):
- """Build and return the complete BuildFactory.
-
- role: string; type of builder.
- clobber: boolean indicating whether we should clean before building
- """
- if role != builder_name_schema.BUILDER_ROLE_HOUSEKEEPER:
- raise Exception('Housekeeping builders must have role "%s"' %
- builder_name_schema.BUILDER_ROLE_HOUSEKEEPER)
-
- self.UpdateSteps()
- if clobber is None:
- clobber = self._default_clobber
- if clobber:
- self.AddSlaveScript(script='clean.py', description='Clean')
-
- # pylint: disable=W0212
- clang_static_analyzer_script_path = self.TargetPath.join(
- self._skia_cmd_obj._local_slave_script_dir,
- 'run-clang-static-analyzer.sh')
- self._skia_cmd_obj.AddRunCommand(
- command=clang_static_analyzer_script_path,
- description='RunClangStaticAnalyzer')
-
- self.AddSlaveScript(script='check_gs_timestamps.py',
- description='CheckGoogleStorageTimestamps')
-
- if not self._do_patch_step: # Do not run the checkers if it is a try job.
- # pylint: disable=W0212
- disk_usage_script_path = self.TargetPath.join(
- self._skia_cmd_obj._local_slave_script_dir,
- 'check_compute_engine_disk_usage.sh')
- self._skia_cmd_obj.AddRunCommand(
- command=('SKIA_COMPUTE_ENGINE_HOSTNAME=%s PERSISTENT_DISK_NAME='
- '/home/default/skia-repo %s'
- % (SKIA_PUBLIC_MASTER_INTERNAL_FQDN,
- disk_usage_script_path)),
- description='CheckMasterDiskUsage')
-
- self.Validate()
- return self
« no previous file with comments | « master/skia_master_scripts/housekeeping_percommit_factory.py ('k') | master/skia_master_scripts/ios_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698