Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 648303002: Correct logic to bind "encrypted" event in EME player_utils.js. (Closed)

Created:
6 years, 2 months ago by sandersd (OOO until July 31)
Modified:
6 years, 2 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct logic to bind "encrypted" event in EME player_utils.js. (New logic is always bind both "encrypted" and "needkey".) BUG=416986, 224786 Committed: https://crrev.com/8163d134ca19f57024ff96a3a4522ce1489ceee7 Cr-Commit-Position: refs/heads/master@{#299346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M media/test/data/eme_player_js/player_utils.js View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sandersd (OOO until July 31)
6 years, 2 months ago (2014-10-13 18:42:35 UTC) #1
ddorwin
lgtm
6 years, 2 months ago (2014-10-13 18:44:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648303002/1
6 years, 2 months ago (2014-10-13 18:46:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 19:42:54 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:43:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8163d134ca19f57024ff96a3a4522ce1489ceee7
Cr-Commit-Position: refs/heads/master@{#299346}

Powered by Google App Engine
This is Rietveld 408576698