DescriptionRemove TestNetworkPredictionEnabledPref.
TestNetworkPredictionEnabledPref is a quite useless test: it verifies that a
preference is at its default value, then essentialy checks that PrefService
accessors work. This is not what the test was meant to test for, see
comments in https://chromiumcodereview.appspot.com/21432002/diff/1/chrome/browser/prefs/pref_functional_browsertest.cc
for the original discussion. Can we please just get rid of this test?
The first patch shows how I whould have proposed to update the test to use
kNetworkPredictionOptions instead of the obsolete kNetworkPredictionEnabled,
if the test had needed to stay.
BUG=334602
Committed: https://crrev.com/a75ca453dc5b2c05e8a2a616c9e00227fd3ab766
Cr-Commit-Position: refs/heads/master@{#299474}
Patch Set 1 #Patch Set 2 : Remove TestNetworkPredictionEnabledPref. #Messages
Total messages: 9 (2 generated)
|