Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 648293002: Remove TestNetworkPredictionEnabledPref. (Closed)

Created:
6 years, 2 months ago by Bence
Modified:
6 years, 2 months ago
Reviewers:
battre
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove TestNetworkPredictionEnabledPref. TestNetworkPredictionEnabledPref is a quite useless test: it verifies that a preference is at its default value, then essentialy checks that PrefService accessors work. This is not what the test was meant to test for, see comments in https://chromiumcodereview.appspot.com/21432002/diff/1/chrome/browser/prefs/pref_functional_browsertest.cc for the original discussion. Can we please just get rid of this test? The first patch shows how I whould have proposed to update the test to use kNetworkPredictionOptions instead of the obsolete kNetworkPredictionEnabled, if the test had needed to stay. BUG=334602 Committed: https://crrev.com/a75ca453dc5b2c05e8a2a616c9e00227fd3ab766 Cr-Commit-Position: refs/heads/master@{#299474}

Patch Set 1 #

Patch Set 2 : Remove TestNetworkPredictionEnabledPref. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Bence
PTAL. Thank you.
6 years, 2 months ago (2014-10-13 18:47:37 UTC) #2
battre
Feel free to just remove this test.
6 years, 2 months ago (2014-10-14 07:19:35 UTC) #3
Bence
PTAL.
6 years, 2 months ago (2014-10-14 13:51:12 UTC) #4
battre
lgtm
6 years, 2 months ago (2014-10-14 14:02:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648293002/130001
6 years, 2 months ago (2014-10-14 14:02:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:130001)
6 years, 2 months ago (2014-10-14 14:12:47 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 14:13:36 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a75ca453dc5b2c05e8a2a616c9e00227fd3ab766
Cr-Commit-Position: refs/heads/master@{#299474}

Powered by Google App Engine
This is Rietveld 408576698