Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 648273002: Remove unused ScrollAnimatorNone::PerAxisData constructor argument. (Closed)

Created:
6 years, 2 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, mkwst+moarreviews_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused ScrollAnimatorNone::PerAxisData constructor argument. The 'parent' argument is not used, remove it. This implicitly fixes an incorrect invocation of the constructor from ScrollAnimatorNoneTest::SavePerAxisData, which following r183583 was passing in an uninitialized pointer value as argument. R=mkwst BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M Source/platform/scroll/ScrollAnimatorNone.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollAnimatorNone.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/ScrollAnimatorNoneTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sof
Please take a look. See https://codereview.chromium.org/603193005/#msg46 for the untidiness uncovered.
6 years, 2 months ago (2014-10-13 18:05:40 UTC) #2
Mike West
Based on that thread, and the fact that everything still seems to work, LGTM. Thanks ...
6 years, 2 months ago (2014-10-13 18:25:05 UTC) #3
sof
On 2014/10/13 18:25:05, Mike West wrote: > Based on that thread, and the fact that ...
6 years, 2 months ago (2014-10-13 19:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648273002/1
6 years, 2 months ago (2014-10-13 19:17:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183625
6 years, 2 months ago (2014-10-13 20:11:13 UTC) #7
haraken
6 years, 2 months ago (2014-10-13 23:27:53 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698