DevTools: [Console] checkbox to hide network messages

DevTools: [Console] checkbox to hide network messages

The patch adds a checkbox to the filter toolbar in console to hide
all console messages with "network" source.

BUG=124534
R=vsevik, pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183690

[lushnikov, 2014-10-13 17:38:54]

please, take a look

[vsevik, 2014-10-13 18:15:13]

On 2014/10/13 17:38:54, lushnikov wrote:
> please, take a look

screenshot?

[eustas, 2014-10-14 06:32:24]

eustas@chromium.org changed reviewers:
+ eustas@chromium.org

[eustas, 2014-10-14 06:32:25]

https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/components/FilterBar.js (right):

https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/components/FilterBar.js:725: this._setting.set(state);
You should change setting instead - the change will be processed by
_settingChanged

[lushnikov, 2014-10-14 07:51:29]

https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
File Source/devtools/front_end/components/FilterBar.js (right):

https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
Source/devtools/front_end/components/FilterBar.js:725: this._setting.set(state);
On 2014/10/14 06:32:25, eustas wrote:
> You should change setting instead - the change will be processed by
> _settingChanged

Two-way binging looks like a good thing here - why don't we want it?

[eustas, 2014-10-14 08:36:27]

On 2014/10/14 07:51:29, lushnikov wrote:
>
https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
> File Source/devtools/front_end/components/FilterBar.js (right):
> 
>
https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
> Source/devtools/front_end/components/FilterBar.js:725:
this._setting.set(state);
> On 2014/10/14 06:32:25, eustas wrote:
> > You should change setting instead - the change will be processed by
> > _settingChanged
> 
> Two-way binging looks like a good thing here - why don't we want it?

This will cause recurring change - setState -> _setting.set -> ... ->
_settingChanged

[lushnikov, 2014-10-14 11:29:28]

On 2014/10/14 08:36:27, eustas wrote:
> On 2014/10/14 07:51:29, lushnikov wrote:
> >
>
https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
> > File Source/devtools/front_end/components/FilterBar.js (right):
> > 
> >
>
https://codereview.chromium.org/648263002/diff/1/Source/devtools/front_end/co...
> > Source/devtools/front_end/components/FilterBar.js:725:
> this._setting.set(state);
> > On 2014/10/14 06:32:25, eustas wrote:
> > > You should change setting instead - the change will be processed by
> > > _settingChanged
> > 
> > Two-way binging looks like a good thing here - why don't we want it?
> 
> This will cause recurring change - setState -> _setting.set -> ... ->
> _settingChanged

It won't as setState is a public interface method which is not used as
changeListener; however, the update method was called twice and i fixed it.
Thanks!

[vsevik, 2014-10-14 11:47:47]

lgtm,
we need to make sure that all checkboxes in such UIs
1) look the same
2) are aligned vertically with text
This could be done in a separate patch though.

[lushnikov, 2014-10-14 12:51:32]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-10-14 12:52:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/648263002/80001

[commit-bot: I haz the power, 2014-10-14 15:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-14 15:12:04]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/31709)

[lushnikov, 2014-10-14 17:06:30]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2014-10-14 17:07:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/648263002/80001

[commit-bot: I haz the power, 2014-10-14 18:20:17]

Committed patchset #2 (id:80001) as 183690