Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 648243002: Always compile functions in the snapshot with deoptimization support. (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Always compile functions in the snapshot with deoptimization support. This prevents an unnecessary deopt-reopt cycle due to type feedback having been thrown away as part of recompiling with deopt support. (For non-snapshotted functions this is not an issue.) Bonus: Add missing space in --trace-ic output, and provide names for PropertyDescriptor's methods, because passing anonymous functions to SetUpLockedPrototype frightens and confuses our FuncNameInferrer. R=hpayer@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24592

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : bump up size of first old_pointer_space page #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M src/compiler.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/spaces.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 1 chunk +21 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
As discussed.
6 years, 2 months ago (2014-10-13 15:31:15 UTC) #2
Yang
lgtm.
6 years, 2 months ago (2014-10-13 16:06:30 UTC) #3
Jakob Kummerow
Had to bump up the size of old_pointer_space's first page, per discussion with Hannes.
6 years, 2 months ago (2014-10-13 17:04:09 UTC) #5
Hannes Payer (out of office)
lgtm, I like 128.
6 years, 2 months ago (2014-10-14 05:08:07 UTC) #6
Hannes Payer (out of office)
lgtm, I like 128.
6 years, 2 months ago (2014-10-14 05:08:07 UTC) #7
Jakob Kummerow
6 years, 2 months ago (2014-10-14 09:59:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:100001) manually as 24592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698