Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4943)

Unified Diff: chrome/browser/translate/translate_browser_metrics.cc

Issue 64823005: Copy the implementations of TranslateUIDelegate to TransalteInfobarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's review (2) Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_browser_metrics.cc
diff --git a/chrome/browser/translate/translate_browser_metrics.cc b/chrome/browser/translate/translate_browser_metrics.cc
index a6605bd4e47e100ce44d853d58d84d6f1747e49d..89f61332f89f395501572f81af6078bc8a96c053 100644
--- a/chrome/browser/translate/translate_browser_metrics.cc
+++ b/chrome/browser/translate/translate_browser_metrics.cc
@@ -25,6 +25,14 @@ const char kTranslateUndisplayableLanguage[] =
"Translate.UndisplayableLanguage";
const char kTranslateUnsupportedLanguageAtInitiation[] =
"Translate.UnsupportedLanguageAtInitiation";
+const char kTranslateDeclineTranslate[] = "Translate.DeclineTranslate";
+const char kTranslateRevertTranslation[] = "Translate.RevertTranslation";
Takashi Toyoshima 2013/11/12 22:16:56 Ah, I see. The UMA strings was originally unsymmet
hajimehoshi 2013/11/13 01:15:20 Thanks, but I prefer each variable name matches ea
+const char kTranslatePerformTranslate[] = "Translate.Translate";
+const char kTranslateNeverTranslateLang[] = "Translate.NeverTranslateLang";
+const char kTranslateNeverTranslateSite[] = "Translate.NeverTranslateSite";
+const char kTranslateAlwaysTranslateLang[] = "Translate.AlwaysTranslateLang";
+const char kTranslateModifyOriginalLang[] = "Translate.ModifyOriginalLang";
+const char kTranslateModifyTargetLang[] = "Translate.ModifyTargetLang";
struct MetricsEntry {
TranslateBrowserMetrics::MetricsNameIndex index;
@@ -43,6 +51,22 @@ const MetricsEntry kMetricsEntries[] = {
kTranslateUndisplayableLanguage },
{ TranslateBrowserMetrics::UMA_UNSUPPORTED_LANGUAGE_AT_INITIATION,
kTranslateUnsupportedLanguageAtInitiation },
+ { TranslateBrowserMetrics::UMA_DECLINE_TRANSLATE,
+ kTranslateDeclineTranslate },
+ { TranslateBrowserMetrics::UMA_REVERT_TRANSLATION,
+ kTranslateRevertTranslation },
+ { TranslateBrowserMetrics::UMA_PERFORM_TRANSLATE,
+ kTranslatePerformTranslate },
+ { TranslateBrowserMetrics::UMA_NEVER_TRANSLATE_LANG,
+ kTranslateNeverTranslateLang },
+ { TranslateBrowserMetrics::UMA_NEVER_TRANSLATE_SITE,
+ kTranslateNeverTranslateSite },
+ { TranslateBrowserMetrics::UMA_ALWAYS_TRANSLATE_LANG,
+ kTranslateAlwaysTranslateLang },
+ { TranslateBrowserMetrics::UMA_MODIFY_ORIGINAL_LANG,
+ kTranslateModifyOriginalLang },
+ { TranslateBrowserMetrics::UMA_MODIFY_TARGET_LANG,
+ kTranslateModifyTargetLang },
};
COMPILE_ASSERT(arraysize(kMetricsEntries) == TranslateBrowserMetrics::UMA_MAX,

Powered by Google App Engine
This is Rietveld 408576698