Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: chrome/browser/translate/translate_ui_delegate.cc

Issue 64823005: Copy the implementations of TranslateUIDelegate to TransalteInfobarDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Peter's review Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_ui_delegate.h" 5 #include "chrome/browser/translate/translate_ui_delegate.h"
6 6
7 #include "base/i18n/string_compare.h" 7 #include "base/i18n/string_compare.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
11 #include "chrome/browser/translate/translate_browser_metrics.h"
11 #include "chrome/browser/translate/translate_manager.h" 12 #include "chrome/browser/translate/translate_manager.h"
12 #include "chrome/browser/translate/translate_prefs.h" 13 #include "chrome/browser/translate/translate_prefs.h"
13 #include "chrome/browser/translate/translate_tab_helper.h" 14 #include "chrome/browser/translate/translate_tab_helper.h"
14 #include "components/translate/common/translate_constants.h" 15 #include "components/translate/common/translate_constants.h"
15 #include "content/public/browser/browser_context.h" 16 #include "content/public/browser/browser_context.h"
16 #include "content/public/browser/navigation_entry.h" 17 #include "content/public/browser/navigation_entry.h"
17 #include "content/public/browser/web_contents.h" 18 #include "content/public/browser/web_contents.h"
18 #include "third_party/icu/source/i18n/unicode/coll.h" 19 #include "third_party/icu/source/i18n/unicode/coll.h"
19 #include "ui/base/l10n/l10n_util.h" 20 #include "ui/base/l10n/l10n_util.h"
20 21
21 namespace { 22 // Note: TranslateInfobarDelegate should be updated if this implementation is
22 23 // updated.
23 const char kDeclineTranslate[] = "Translate.DeclineTranslate";
24 const char kRevertTranslation[] = "Translate.RevertTranslation";
25 const char kPerformTranslate[] = "Translate.Translate";
26 const char kNeverTranslateLang[] = "Translate.NeverTranslateLang";
27 const char kNeverTranslateSite[] = "Translate.NeverTranslateSite";
28 const char kAlwaysTranslateLang[] = "Translate.AlwaysTranslateLang";
29 const char kModifyOriginalLang[] = "Translate.ModifyOriginalLang";
30 const char kModifyTargetLang[] = "Translate.ModifyTargetLang";
31
32 } // namespace
33 24
34 TranslateUIDelegate::TranslateUIDelegate(content::WebContents* web_contents, 25 TranslateUIDelegate::TranslateUIDelegate(content::WebContents* web_contents,
35 const std::string& original_language, 26 const std::string& original_language,
36 const std::string& target_language) 27 const std::string& target_language)
37 : web_contents_(web_contents), 28 : web_contents_(web_contents),
38 original_language_index_(NO_INDEX), 29 original_language_index_(NO_INDEX),
39 initial_original_language_index_(NO_INDEX),
40 target_language_index_(NO_INDEX) { 30 target_language_index_(NO_INDEX) {
41 std::vector<std::string> language_codes; 31 languages_ =
42 TranslateManager::GetSupportedLanguages(&language_codes); 32 GetSortedLanguageNames(g_browser_process->GetApplicationLocale());
43 33
44 // Preparing for the alphabetical order in the locale.
45 UErrorCode error = U_ZERO_ERROR;
46 std::string locale = g_browser_process->GetApplicationLocale();
47 icu::Locale loc(locale.c_str());
48 scoped_ptr<icu::Collator> collator(icu::Collator::createInstance(loc, error));
49 collator->setStrength(icu::Collator::PRIMARY);
50
51 languages_.reserve(language_codes.size());
52 for (std::vector<std::string>::const_iterator iter = language_codes.begin();
53 iter != language_codes.end(); ++iter) {
54 std::string language_code = *iter;
55
56 string16 language_name = l10n_util::GetDisplayNameForLocale(
57 language_code, g_browser_process->GetApplicationLocale(), true);
58 // Insert the language in languages_ in alphabetical order.
59 std::vector<LanguageNamePair>::iterator iter2;
60 for (iter2 = languages_.begin(); iter2 != languages_.end(); ++iter2) {
61 if (base::i18n::CompareString16WithCollator(collator.get(),
62 language_name, iter2->second) == UCOL_LESS) {
63 break;
64 }
65 }
66 languages_.insert(iter2, LanguageNamePair(language_code, language_name));
67 }
68 for (std::vector<LanguageNamePair>::const_iterator iter = languages_.begin(); 34 for (std::vector<LanguageNamePair>::const_iterator iter = languages_.begin();
69 iter != languages_.end(); ++iter) { 35 iter != languages_.end(); ++iter) {
70 std::string language_code = iter->first; 36 std::string language_code = iter->first;
71 if (language_code == original_language) { 37 if (language_code == original_language)
72 original_language_index_ = iter - languages_.begin(); 38 original_language_index_ = iter - languages_.begin();
73 initial_original_language_index_ = original_language_index_;
74 }
75 if (language_code == target_language) 39 if (language_code == target_language)
76 target_language_index_ = iter - languages_.begin(); 40 target_language_index_ = iter - languages_.begin();
77 } 41 }
78 42
79 Profile* profile = 43 Profile* profile =
80 Profile::FromBrowserContext(web_contents->GetBrowserContext()); 44 Profile::FromBrowserContext(web_contents->GetBrowserContext());
81 prefs_.reset(new TranslatePrefs(profile->GetPrefs())); 45 prefs_.reset(new TranslatePrefs(profile->GetPrefs()));
82 } 46 }
83 47
84 TranslateUIDelegate::~TranslateUIDelegate() { 48 TranslateUIDelegate::~TranslateUIDelegate() {
85 } 49 }
86 50
51 // static
52 std::vector<TranslateUIDelegate::LanguageNamePair>
53 TranslateUIDelegate::GetSortedLanguageNames(const std::string& locale) {
Peter Kasting 2013/11/12 00:03:27 Nit: Indent 4
hajimehoshi 2013/11/12 03:07:25 Done.
54 std::vector<LanguageNamePair> language_names;
Peter Kasting 2013/11/12 00:03:27 Nit: Declare this where first used
hajimehoshi 2013/11/12 03:07:25 Done.
55
56 std::vector<std::string> language_codes;
57 TranslateManager::GetSupportedLanguages(&language_codes);
58
59 // Preparing for the alphabetical order in the locale.
60 UErrorCode error = U_ZERO_ERROR;
61 icu::Locale loc(locale.c_str());
62 scoped_ptr<icu::Collator> collator(icu::Collator::createInstance(loc, error));
63 collator->setStrength(icu::Collator::PRIMARY);
64
65 language_names.reserve(language_codes.size());
66 for (std::vector<std::string>::const_iterator iter = language_codes.begin();
67 iter != language_codes.end(); ++iter) {
68 std::string language_code = *iter;
69
70 string16 language_name = l10n_util::GetDisplayNameForLocale(
71 language_code, locale, true);
72 // Insert the language in |language_names| in alphabetical order.
73 std::vector<LanguageNamePair>::iterator iter2;
74 for (iter2 = language_names.begin(); iter2 != language_names.end();
75 ++iter2) {
76 if (base::i18n::CompareString16WithCollator(collator.get(),
77 language_name, iter2->second) == UCOL_LESS) {
78 break;
79 }
80 }
81 language_names.insert(iter2,
82 LanguageNamePair(language_code, language_name));
83 }
84
85 return language_names;
86 }
87
88 // static
89 std::string TranslateUIDelegate::GetPageHost(
90 content::WebContents* web_contents) {
91 content::NavigationEntry* entry =
92 web_contents->GetController().GetActiveEntry();
93 return entry ? entry->GetURL().HostNoBrackets() : std::string();
94 }
95
87 size_t TranslateUIDelegate::GetNumberOfLanguages() const { 96 size_t TranslateUIDelegate::GetNumberOfLanguages() const {
88 return languages_.size(); 97 return languages_.size();
89 } 98 }
90 99
91 size_t TranslateUIDelegate::GetOriginalLanguageIndex() const { 100 size_t TranslateUIDelegate::GetOriginalLanguageIndex() const {
92 return original_language_index_; 101 return original_language_index_;
93 } 102 }
94 103
95 void TranslateUIDelegate::UpdateOriginalLanguageIndex(size_t language_index) { 104 void TranslateUIDelegate::UpdateOriginalLanguageIndex(size_t language_index) {
96 if (original_language_index_ == language_index) 105 if (original_language_index_ == language_index)
97 return; 106 return;
98 107
99 UMA_HISTOGRAM_BOOLEAN(kModifyOriginalLang, true); 108 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
109 TranslateBrowserMetrics::UMA_MODIFY_ORIGINAL_LANG), true);
100 original_language_index_ = language_index; 110 original_language_index_ = language_index;
101 } 111 }
102 112
103 size_t TranslateUIDelegate::GetTargetLanguageIndex() const { 113 size_t TranslateUIDelegate::GetTargetLanguageIndex() const {
104 return target_language_index_; 114 return target_language_index_;
105 } 115 }
106 116
107 void TranslateUIDelegate::UpdateTargetLanguageIndex(size_t language_index) { 117 void TranslateUIDelegate::UpdateTargetLanguageIndex(size_t language_index) {
108 if (target_language_index_ == language_index) 118 if (target_language_index_ == language_index)
109 return; 119 return;
110 120
111 DCHECK_LT(language_index, GetNumberOfLanguages()); 121 DCHECK_LT(language_index, GetNumberOfLanguages());
112 UMA_HISTOGRAM_BOOLEAN(kModifyTargetLang, true); 122 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
123 TranslateBrowserMetrics::UMA_MODIFY_TARGET_LANG), true);
113 target_language_index_ = language_index; 124 target_language_index_ = language_index;
114 } 125 }
115 126
116 127
117 std::string TranslateUIDelegate::GetLanguageCodeAt(size_t index) const { 128 std::string TranslateUIDelegate::GetLanguageCodeAt(size_t index) const {
118 DCHECK_LT(index, GetNumberOfLanguages()); 129 DCHECK_LT(index, GetNumberOfLanguages());
119 return languages_[index].first; 130 return languages_[index].first;
120 } 131 }
121 132
122 string16 TranslateUIDelegate::GetLanguageNameAt(size_t index) const { 133 string16 TranslateUIDelegate::GetLanguageNameAt(size_t index) const {
(...skipping 15 matching lines...) Expand all
138 149
139 void TranslateUIDelegate::Translate() { 150 void TranslateUIDelegate::Translate() {
140 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) { 151 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) {
141 prefs_->ResetTranslationDeniedCount(GetOriginalLanguageCode()); 152 prefs_->ResetTranslationDeniedCount(GetOriginalLanguageCode());
142 prefs_->IncrementTranslationAcceptedCount(GetOriginalLanguageCode()); 153 prefs_->IncrementTranslationAcceptedCount(GetOriginalLanguageCode());
143 } 154 }
144 TranslateManager::GetInstance()->TranslatePage(web_contents(), 155 TranslateManager::GetInstance()->TranslatePage(web_contents(),
145 GetOriginalLanguageCode(), 156 GetOriginalLanguageCode(),
146 GetTargetLanguageCode()); 157 GetTargetLanguageCode());
147 158
148 UMA_HISTOGRAM_BOOLEAN(kPerformTranslate, true); 159 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
160 TranslateBrowserMetrics::UMA_PERFORM_TRANSLATE), true);
149 } 161 }
150 162
151 void TranslateUIDelegate::RevertTranslation() { 163 void TranslateUIDelegate::RevertTranslation() {
152 TranslateManager::GetInstance()->RevertTranslation(web_contents()); 164 TranslateManager::GetInstance()->RevertTranslation(web_contents());
153 165
154 UMA_HISTOGRAM_BOOLEAN(kRevertTranslation, true); 166 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
167 TranslateBrowserMetrics::UMA_REVERT_TRANSLATION), true);
155 } 168 }
156 169
157 void TranslateUIDelegate::TranslationDeclined() { 170 void TranslateUIDelegate::TranslationDeclined() {
158 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) { 171 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) {
159 prefs_->ResetTranslationAcceptedCount(GetOriginalLanguageCode()); 172 prefs_->ResetTranslationAcceptedCount(GetOriginalLanguageCode());
160 prefs_->IncrementTranslationDeniedCount(GetOriginalLanguageCode()); 173 prefs_->IncrementTranslationDeniedCount(GetOriginalLanguageCode());
161 } 174 }
162 175
163 // Remember that the user declined the translation so as to prevent showing a 176 // Remember that the user declined the translation so as to prevent showing a
164 // translate infobar for that page again. (TranslateManager initiates 177 // translate infobar for that page again. (TranslateManager initiates
165 // translations when getting a LANGUAGE_DETERMINED from the page, which 178 // translations when getting a LANGUAGE_DETERMINED from the page, which
166 // happens when a load stops. That could happen multiple times, including 179 // happens when a load stops. That could happen multiple times, including
167 // after the user already declined the translation.) 180 // after the user already declined the translation.)
168 TranslateTabHelper::FromWebContents(web_contents())-> 181 TranslateTabHelper::FromWebContents(web_contents())->
169 language_state().set_translation_declined(true); 182 language_state().set_translation_declined(true);
170 183
171 UMA_HISTOGRAM_BOOLEAN(kDeclineTranslate, true); 184 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
185 TranslateBrowserMetrics::UMA_DECLINE_TRANSLATE), true);
172 } 186 }
173 187
174 bool TranslateUIDelegate::IsLanguageBlocked() { 188 bool TranslateUIDelegate::IsLanguageBlocked() {
175 return prefs_->IsBlockedLanguage(GetOriginalLanguageCode()); 189 return prefs_->IsBlockedLanguage(GetOriginalLanguageCode());
176 } 190 }
177 191
178 void TranslateUIDelegate::SetLanguageBlocked(bool value) { 192 void TranslateUIDelegate::SetLanguageBlocked(bool value) {
179 if (value) { 193 if (value) {
180 prefs_->BlockLanguage(GetOriginalLanguageCode()); 194 prefs_->BlockLanguage(GetOriginalLanguageCode());
181 TranslateTabHelper* translate_tab_helper = 195 TranslateTabHelper* translate_tab_helper =
182 TranslateTabHelper::FromWebContents(web_contents()); 196 TranslateTabHelper::FromWebContents(web_contents());
183 DCHECK(translate_tab_helper); 197 DCHECK(translate_tab_helper);
184 translate_tab_helper->language_state().SetTranslateEnabled(false); 198 translate_tab_helper->language_state().SetTranslateEnabled(false);
185 } else { 199 } else {
186 prefs_->UnblockLanguage(GetOriginalLanguageCode()); 200 prefs_->UnblockLanguage(GetOriginalLanguageCode());
187 } 201 }
188 202
189 UMA_HISTOGRAM_BOOLEAN(kNeverTranslateLang, true); 203 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
204 TranslateBrowserMetrics::UMA_NEVER_TRANSLATE_LANG), true);
190 } 205 }
191 206
192 bool TranslateUIDelegate::IsSiteBlacklisted() { 207 bool TranslateUIDelegate::IsSiteBlacklisted() {
193 std::string host = GetPageHost(); 208 std::string host = GetPageHost(web_contents());
194 return !host.empty() && prefs_->IsSiteBlacklisted(host); 209 return !host.empty() && prefs_->IsSiteBlacklisted(host);
195 } 210 }
196 211
197 void TranslateUIDelegate::SetSiteBlacklist(bool value) { 212 void TranslateUIDelegate::SetSiteBlacklist(bool value) {
198 std::string host = GetPageHost(); 213 std::string host = GetPageHost(web_contents());
199 if (host.empty()) 214 if (host.empty())
200 return; 215 return;
201 216
202 if (value) { 217 if (value) {
203 prefs_->BlacklistSite(host); 218 prefs_->BlacklistSite(host);
204 TranslateTabHelper* translate_tab_helper = 219 TranslateTabHelper* translate_tab_helper =
205 TranslateTabHelper::FromWebContents(web_contents()); 220 TranslateTabHelper::FromWebContents(web_contents());
206 DCHECK(translate_tab_helper); 221 DCHECK(translate_tab_helper);
207 translate_tab_helper->language_state().SetTranslateEnabled(false); 222 translate_tab_helper->language_state().SetTranslateEnabled(false);
208 } else { 223 } else {
209 prefs_->RemoveSiteFromBlacklist(host); 224 prefs_->RemoveSiteFromBlacklist(host);
210 } 225 }
211 226
212 UMA_HISTOGRAM_BOOLEAN(kNeverTranslateSite, true); 227 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
228 TranslateBrowserMetrics::UMA_NEVER_TRANSLATE_SITE), true);
213 } 229 }
214 230
215 bool TranslateUIDelegate::ShouldAlwaysTranslate() { 231 bool TranslateUIDelegate::ShouldAlwaysTranslate() {
216 return prefs_->IsLanguagePairWhitelisted(GetOriginalLanguageCode(), 232 return prefs_->IsLanguagePairWhitelisted(GetOriginalLanguageCode(),
217 GetTargetLanguageCode()); 233 GetTargetLanguageCode());
218 } 234 }
219 235
220 void TranslateUIDelegate::SetAlwaysTranslate(bool value) { 236 void TranslateUIDelegate::SetAlwaysTranslate(bool value) {
221 const std::string& original_lang = GetOriginalLanguageCode(); 237 const std::string& original_lang = GetOriginalLanguageCode();
222 const std::string& target_lang = GetTargetLanguageCode(); 238 const std::string& target_lang = GetTargetLanguageCode();
223 if (value) 239 if (value)
224 prefs_->WhitelistLanguagePair(original_lang, target_lang); 240 prefs_->WhitelistLanguagePair(original_lang, target_lang);
225 else 241 else
226 prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang); 242 prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang);
227 243
228 UMA_HISTOGRAM_BOOLEAN(kAlwaysTranslateLang, true); 244 UMA_HISTOGRAM_BOOLEAN(TranslateBrowserMetrics::GetMetricsName(
245 TranslateBrowserMetrics::UMA_ALWAYS_TRANSLATE_LANG), true);
229 } 246 }
230
231 std::string TranslateUIDelegate::GetPageHost() {
232 content::NavigationEntry* entry =
233 web_contents()->GetController().GetActiveEntry();
234 return entry ? entry->GetURL().HostNoBrackets() : std::string();
235 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698