Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 648213003: Restrict alt data reduction proxy to Android dev channel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1856 matching lines...) Expand 10 before | Expand all | Expand 10 after
1867 #if defined(OS_ANDROID) 1867 #if defined(OS_ANDROID)
1868 { 1868 {
1869 "enable-data-reduction-proxy-dev", 1869 "enable-data-reduction-proxy-dev",
1870 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_DEV_NAME, 1870 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_DEV_NAME,
1871 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_DEV_DESCRIPTION, 1871 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_DEV_DESCRIPTION,
1872 kOsAndroid, 1872 kOsAndroid,
1873 ENABLE_DISABLE_VALUE_TYPE( 1873 ENABLE_DISABLE_VALUE_TYPE(
1874 data_reduction_proxy::switches::kEnableDataReductionProxyDev, 1874 data_reduction_proxy::switches::kEnableDataReductionProxyDev,
1875 data_reduction_proxy::switches::kDisableDataReductionProxyDev) 1875 data_reduction_proxy::switches::kDisableDataReductionProxyDev)
1876 }, 1876 },
1877 {
1878 "enable-data-reduction-proxy-alt",
1879 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_ALTERNATIVE_NAME,
1880 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_ALTERNATIVE_DESCRIPTION,
1881 kOsAndroid,
1882 SINGLE_VALUE_TYPE(
1883 data_reduction_proxy::switches::kEnableDataReductionProxyAlt)
1884 },
1877 #endif 1885 #endif
1878 { 1886 {
1879 "enable-experimental-hotwording", 1887 "enable-experimental-hotwording",
1880 IDS_FLAGS_ENABLE_EXPERIMENTAL_HOTWORDING_NAME, 1888 IDS_FLAGS_ENABLE_EXPERIMENTAL_HOTWORDING_NAME,
1881 IDS_FLAGS_ENABLE_EXPERIMENTAL_HOTWORDING_DESCRIPTION, 1889 IDS_FLAGS_ENABLE_EXPERIMENTAL_HOTWORDING_DESCRIPTION,
1882 kOsDesktop, 1890 kOsDesktop,
1883 SINGLE_VALUE_TYPE(switches::kEnableExperimentalHotwording) 1891 SINGLE_VALUE_TYPE(switches::kEnableExperimentalHotwording)
1884 }, 1892 },
1885 #if defined(ENABLE_EXTENSIONS) 1893 #if defined(ENABLE_EXTENSIONS)
1886 { 1894 {
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
1940 #endif 1948 #endif
1941 #if defined(OS_CHROMEOS) 1949 #if defined(OS_CHROMEOS)
1942 { 1950 {
1943 "wake-on-packets", 1951 "wake-on-packets",
1944 IDS_FLAGS_WAKE_ON_PACKETS_NAME, 1952 IDS_FLAGS_WAKE_ON_PACKETS_NAME,
1945 IDS_FLAGS_WAKE_ON_PACKETS_DESCRIPTION, 1953 IDS_FLAGS_WAKE_ON_PACKETS_DESCRIPTION,
1946 kOsCrOSOwnerOnly, 1954 kOsCrOSOwnerOnly,
1947 SINGLE_VALUE_TYPE(chromeos::switches::kWakeOnPackets) 1955 SINGLE_VALUE_TYPE(chromeos::switches::kWakeOnPackets)
1948 }, 1956 },
1949 #endif // OS_CHROMEOS 1957 #endif // OS_CHROMEOS
1950 {
1951 "enable-data-reduction-proxy-alt",
1952 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_ALTERNATIVE_NAME,
1953 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_ALTERNATIVE_DESCRIPTION,
1954 kOsAndroid,
1955 SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
1956 kEnableDataReductionProxyAlt)
1957 },
1958 #if defined(USE_AURA) 1958 #if defined(USE_AURA)
1959 { 1959 {
1960 "enable-tab-audio-muting", 1960 "enable-tab-audio-muting",
1961 IDS_FLAGS_ENABLE_TAB_AUDIO_MUTING_NAME, 1961 IDS_FLAGS_ENABLE_TAB_AUDIO_MUTING_NAME,
1962 IDS_FLAGS_ENABLE_TAB_AUDIO_MUTING_DESCRIPTION, 1962 IDS_FLAGS_ENABLE_TAB_AUDIO_MUTING_DESCRIPTION,
1963 kOsWin | kOsLinux | kOsCrOS, 1963 kOsWin | kOsLinux | kOsCrOS,
1964 SINGLE_VALUE_TYPE(switches::kEnableTabAudioMuting) 1964 SINGLE_VALUE_TYPE(switches::kEnableTabAudioMuting)
1965 }, 1965 },
1966 #endif // defined(USE_AURA) 1966 #endif // defined(USE_AURA)
1967 { 1967 {
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
2116 return true; 2116 return true;
2117 } 2117 }
2118 2118
2119 #if defined(OS_ANDROID) 2119 #if defined(OS_ANDROID)
2120 // enable-data-reduction-proxy-dev is only available for the Dev/Beta channel. 2120 // enable-data-reduction-proxy-dev is only available for the Dev/Beta channel.
2121 if (!strcmp("enable-data-reduction-proxy-dev", experiment.internal_name) && 2121 if (!strcmp("enable-data-reduction-proxy-dev", experiment.internal_name) &&
2122 chrome::VersionInfo::GetChannel() != chrome::VersionInfo::CHANNEL_BETA && 2122 chrome::VersionInfo::GetChannel() != chrome::VersionInfo::CHANNEL_BETA &&
2123 chrome::VersionInfo::GetChannel() != chrome::VersionInfo::CHANNEL_DEV) { 2123 chrome::VersionInfo::GetChannel() != chrome::VersionInfo::CHANNEL_DEV) {
2124 return true; 2124 return true;
2125 } 2125 }
2126 // enable-data-reduction-proxy-alt is only available for the Dev channel.
2127 if (!strcmp("enable-data-reduction-proxy-alt", experiment.internal_name) &&
2128 chrome::VersionInfo::GetChannel() != chrome::VersionInfo::CHANNEL_DEV) {
2129 return true;
2130 }
2126 #endif 2131 #endif
2127 2132
2128 return false; 2133 return false;
2129 } 2134 }
2130 2135
2131 2136
2132 // Variant of GetSanitizedEnabledFlags that also removes any flags that aren't 2137 // Variant of GetSanitizedEnabledFlags that also removes any flags that aren't
2133 // enabled on the current platform. 2138 // enabled on the current platform.
2134 void GetSanitizedEnabledFlagsForCurrentPlatform( 2139 void GetSanitizedEnabledFlagsForCurrentPlatform(
2135 FlagsStorage* flags_storage, std::set<std::string>* result) { 2140 FlagsStorage* flags_storage, std::set<std::string>* result) {
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
2578 } 2583 }
2579 2584
2580 const Experiment* GetExperiments(size_t* count) { 2585 const Experiment* GetExperiments(size_t* count) {
2581 *count = num_experiments; 2586 *count = num_experiments;
2582 return experiments; 2587 return experiments;
2583 } 2588 }
2584 2589
2585 } // namespace testing 2590 } // namespace testing
2586 2591
2587 } // namespace about_flags 2592 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698