Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Issue 6482029: Add support for using ICU with a data file instead of compiling the data in.... (Closed)

Created:
9 years, 10 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Add support for using ICU with a data file instead of compiling the data in. This might help the Mac bots as it means each unittest that depends on base will be ~10meg smaller, helping link and also helping with the copy of bits from the builder to the tester. If Mac ever support a Universal binary (32bit and 64bit) it will also probably want to use this to avoid carrying two copies of the ICU data. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74439

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M third_party/icu/icu.gyp View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
TVL
Mark - Can you take a look. Jungshik - fyi
9 years, 10 months ago (2011-02-10 15:26:42 UTC) #1
Mark Mentovai
Is it then the user’s responsibility to initialize ICU by pointing it to icudt42l.dat? http://codereview.chromium.org/6482029/diff/1/third_party/icu/icu.gyp ...
9 years, 10 months ago (2011-02-10 16:08:11 UTC) #2
TVL
On 2011/02/10 16:08:11, Mark Mentovai wrote: > Is it then the user’s responsibility to initialize ...
9 years, 10 months ago (2011-02-10 16:11:09 UTC) #3
Mark Mentovai
LGTM Can you also merge this patch to /trunk/deps/third_party/icu46?
9 years, 10 months ago (2011-02-10 16:18:34 UTC) #4
TVL
9 years, 10 months ago (2011-02-10 16:22:16 UTC) #5
On 2011/02/10 16:18:34, Mark Mentovai wrote:
> LGTM
> 
> Can you also merge this patch to /trunk/deps/third_party/icu46?

Yup, I'll pull and send out another cl in a little bit.

Powered by Google App Engine
This is Rietveld 408576698