Implement sendKeys webdriver API in ChromeDriver.

Implement Value command in ChromeDriver.
BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74748

[kkania, 2011-02-10 04:31:10]

there's a couple small todo's for some non-windows stuff that I'll do in a
separate CL

All the unittests I wrote pass, and I'll add them to your unittest binary when
that CL is committed.

I couldn't try any of the webdriver tests because most of them depend on some
find element stuff that is broken now.

For some reason the GET_PROPERTY atom wasn't working for me, so I just made my
own custom one for now.

[jleyba, 2011-02-10 05:52:19]

Looks pretty solid.  Can you enable any of the python acceptance tests that go
with this?

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/automati...
File chrome/test/webdriver/automation.h (right):

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/automati...
chrome/test/webdriver/automation.h:33: automation::KeyEventTypes type;
Should these be const?

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/session.cc
File chrome/test/webdriver/session.cc (right):

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/session....
chrome/test/webdriver/session.cc:138: delete unscoped_result;
You leak unscoped_result if code != kSuccess.

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/webdrive...
File chrome/test/webdriver/webdriver_key_converter.cc (right):

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/webdrive...
chrome/test/webdriver/webdriver_key_converter.cc:96: return false;
Unreachable statement

[kkania, 2011-02-10 18:17:48]

Few changes:

1) Added ElementTextCommand, which retrieves visible text. I added this so that
most python acceptance tests would run.

2) Renamed webelement_command to webelement_commands, and put all the web
element commands there.

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/automati...
File chrome/test/webdriver/automation.h (right):

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/automati...
chrome/test/webdriver/automation.h:33: automation::KeyEventTypes type;
On 2011/02/10 05:52:19, jleyba wrote:
> Should these be const?

they could be, but I don't see any compelling reason why they should be

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/session.cc
File chrome/test/webdriver/session.cc (right):

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/session....
chrome/test/webdriver/session.cc:138: delete unscoped_result;
On 2011/02/10 05:52:19, jleyba wrote:
> You leak unscoped_result if code != kSuccess.

Done.

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/webdrive...
File chrome/test/webdriver/webdriver_key_converter.cc (right):

http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/webdrive...
chrome/test/webdriver/webdriver_key_converter.cc:96: return false;
On 2011/02/10 05:52:19, jleyba wrote:
> Unreachable statement

Done.

[Jason Leyba, 2011-02-11 19:29:42]

On 2011/02/10 18:17:48, kkania wrote:
> Few changes:
> 
> 1) Added ElementTextCommand, which retrieves visible text. I added this so
that
> most python acceptance tests would run.
> 
> 2) Renamed webelement_command to webelement_commands, and put all the web
> element commands there.
> 
>
http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/automati...
> File chrome/test/webdriver/automation.h (right):
> 
>
http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/automati...
> chrome/test/webdriver/automation.h:33: automation::KeyEventTypes type;
> On 2011/02/10 05:52:19, jleyba wrote:
> > Should these be const?
> 
> they could be, but I don't see any compelling reason why they should be

Fair enough.  I prefer to make everything const unless it really should be
mutable.

> 
>
http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/session.cc
> File chrome/test/webdriver/session.cc (right):
> 
>
http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/session....
> chrome/test/webdriver/session.cc:138: delete unscoped_result;
> On 2011/02/10 05:52:19, jleyba wrote:
> > You leak unscoped_result if code != kSuccess.
> 
> Done.
> 
>
http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/webdrive...
> File chrome/test/webdriver/webdriver_key_converter.cc (right):
> 
>
http://codereview.chromium.org/6482014/diff/39/chrome/test/webdriver/webdrive...
> chrome/test/webdriver/webdriver_key_converter.cc:96: return false;
> On 2011/02/10 05:52:19, jleyba wrote:
> > Unreachable statement
> 
> Done.

[Jason Leyba, 2011-02-11 19:32:01]

LGTM

http://codereview.chromium.org/6482014/diff/10014/chrome/test/webdriver/webdr...
File chrome/test/webdriver/webdriver_key_converter_unittest.cc (right):

http://codereview.chromium.org/6482014/diff/10014/chrome/test/webdriver/webdr...
chrome/test/webdriver/webdriver_key_converter_unittest.cc:1: // Copyright (c)
2011 The Chromium Authors. All rights reserved.
You didn't add this to chromedriver_unittests in chrome_tests.gypi