Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 648163003: Revert of Revert "Update the tests (ISO-8859-1 => windows-1252)" (Closed)

Created:
6 years, 2 months ago by jungshik at Google
Modified:
6 years, 2 months ago
Reviewers:
cbiesinger
CC:
blink-reviews, mkwst+moarreviews_chromium.org, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, Mikhail
Project:
blink
Visibility:
Public.

Description

Revert of Revert "Update the tests (ISO-8859-1 => windows-1252)" (patchset #1 id:1 of https://codereview.chromium.org/658193002/) Reason for revert: The failing browser tests (Chromium) were temporarily disabled (or made robust against the difference introduced by this Blink CL) in the following Cr CL (that got landed) : https://codereview.chromium.org/643993004/ Original issue's description: > Revert "Update the tests (ISO-8859-1 => windows-1252)" > > This reverts commit 9c188b20fbb4d4c2006ab1a611ed8a9b971e7cee. > > Broke several browser_tests which depended on the previous behavior: > BrowserEncodingTest.TestOverrideEncoding > EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/16 > BrowserEncodingTest.TestEncodingAutoDetect > EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping/3 > > E.g. > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserEncodingTest.TestOverrideEncoding&testType=browser_tests > > TBR=jshin@chromium.org > BUG=412053 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183822 TBR=cbiesinger@chromium.org NOTREECHECKS=true NOTRY=true BUG=412053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -45 lines) Patch
M LayoutTests/fast/encoding/bracket-in-tag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/charset-invalid.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/charset-invalid-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/encoding/charset-replacement.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/charset-replacement-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/encoding/misplaced-xml-declaration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/encoding/pseudo-xml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/encoding/meta-switch-mid-parse-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/char-encoding-in-hidden-charset-field-default.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/misc/frame-default-enc-different-domain-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/TextCodecICU.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M Source/wtf/text/TextCodecLatin1.cpp View 1 chunk +17 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
Created Revert of Revert "Update the tests (ISO-8859-1 => windows-1252)"
6 years, 2 months ago (2014-10-17 06:23:07 UTC) #1
cbiesinger
lgtm
6 years, 2 months ago (2014-10-17 22:10:23 UTC) #2
jungshik at Google
6 years, 2 months ago (2014-10-18 07:23:26 UTC) #3
On 2014/10/17 22:10:23, cbiesinger wrote:
> lgtm

Thanks. I ended up using the original Cl (
https://codereview.chromium.org/655083002/ )

Powered by Google App Engine
This is Rietveld 408576698