Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 648133002: fix newly added OVERRIDEs in chrome/browser/ui/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

fix newly added OVERRIDEs in chrome/browser/ui/ BUG=417463 Committed: https://crrev.com/f165e0a8a059ab186e6cf7affdd87a5048861eb0 Cr-Commit-Position: refs/heads/master@{#299342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/ui/app_list/app_list_prefs_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/model_pref_updater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/model_pref_updater_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Peter: can you please take a look at this trivial fixup? We're getting close to ...
6 years, 2 months ago (2014-10-13 08:25:12 UTC) #2
Peter Kasting
LGTM
6 years, 2 months ago (2014-10-13 17:54:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648133002/1
6 years, 2 months ago (2014-10-13 18:27:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-13 19:25:12 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 19:25:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f165e0a8a059ab186e6cf7affdd87a5048861eb0
Cr-Commit-Position: refs/heads/master@{#299342}

Powered by Google App Engine
This is Rietveld 408576698