Issue 648063002: Fix leak in GLPrograms test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 648063002: Fix leak in GLPrograms test. (Closed)

Created:
6 years, 2 months ago by bsalomon

Modified:
6 years, 2 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix leak in GLPrograms test. TBR=joshualitt@google.com Committed: https://skia.googlesource.com/skia/+/d27726eccbb7d6054f6adeda62a37d77fae11a15

Patch Set 1 #

Patch Set 2 : wrap line #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	tests/GLProgramsTest.cpp	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648063002/30001

6 years, 2 months ago (2014-10-12 12:29:27 UTC) #2

commit-bot: I haz the power

Committed patchset #2 (id:30001) as d27726eccbb7d6054f6adeda62a37d77fae11a15

6 years, 2 months ago (2014-10-12 12:40:26 UTC) #3

joshua.litt

6 years, 2 months ago (2014-10-12 14:24:53 UTC) #4

Message was sent while issue was closed.

On 2014/10/12 12:40:26, I haz the power (commit-bot) wrote:
> Committed patchset #2 (id:30001) as d27726eccbb7d6054f6adeda62a37d77fae11a15

:( Yea there was also a leak in my programs builder rewrite.  I don't think our
release valgrind bot is working.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages