chrome/common/extensions/file_handler_info.cc - Issue 64803005: File association for app shims. (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/file_handler_info.cc

Issue 64803005: File association for app shims. (Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Change FileHandlersInfo to hold a copy. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/file_handler_info.cc

diff --git a/chrome/common/extensions/file_handler_info.cc b/chrome/common/extensions/file_handler_info.cc

index c33356734ebf63377158cd3d4730a427ed5ae480..aeb5e698c60e1633df76a250287c45d9f66ff7df 100644

--- a/chrome/common/extensions/file_handler_info.cc

+++ b/chrome/common/extensions/file_handler_info.cc

@@ -10,7 +10,7 @@ FileHandlerInfo::FileHandlerInfo() {}

FileHandlerInfo::~FileHandlerInfo() {}

FileHandlersInfo::FileHandlersInfo(const std::vector<FileHandlerInfo>* handlers)

- : handlers(handlers) {}

+ : handlers(*handlers) {}

tapted 2014/04/22 05:07:23 There's a call in web_app.cc / CreateShortcutsOnFi

jackhou1 2014/04/22 06:47:25 Ugh of course, sorry. Changed this to just a defa

FileHandlersInfo::~FileHandlersInfo() {}

« no previous file with comments | « chrome/common/extensions/file_handler_info.h ('k') | chrome/common/mac/app_mode_common.h » ('j') | no next file with comments »