File association for app shims. (Mac)

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Carbon/Carbon.h>
 #import <Cocoa/Cocoa.h>
 
 #include "apps/app_shim/app_shim_mac.h"
@@ skipping 423 matching lines @@
   if (!close_callback.is_null())
     close_callback.Run();
 }
 
 }  // namespace chrome
 
 namespace web_app {
 
 WebAppShortcutCreator::WebAppShortcutCreator(
     const base::FilePath& app_data_dir,
-    const ShellIntegration::ShortcutInfo& shortcut_info)
+    const ShellIntegration::ShortcutInfo& shortcut_info,
+    const extensions::FileHandlersInfo& file_handlers_info)
     : app_data_dir_(app_data_dir),
-      info_(shortcut_info) {}
+      info_(shortcut_info),
+      file_handlers_info_(file_handlers_info) {}
 
 WebAppShortcutCreator::~WebAppShortcutCreator() {}
 
 base::FilePath WebAppShortcutCreator::GetApplicationsShortcutPath() const {
   base::FilePath applications_dir = GetApplicationsDirname();
   return applications_dir.empty() ?
       base::FilePath() : applications_dir.Append(GetShortcutBasename());
 }
 
 base::FilePath WebAppShortcutCreator::GetInternalShortcutPath() const {
@@ skipping 160 matching lines @@
 }
 
 base::FilePath WebAppShortcutCreator::GetApplicationsDirname() const {
   base::FilePath path = GetWritableApplicationsDirectory();
   if (path.empty())
     return path;
 
   return path.Append(GetLocalizableAppShortcutsSubdirName());
 }
 
+void UpdateFileTypes(NSMutableDictionary* plist,

[tapted, 2014/04/17 04:37:50]

move to anonymous namespace

[jackhou1, 2014/04/22 04:40:19]

Done.

+                     const extensions::FileHandlersInfo& file_handlers_info) {
+  NSMutableArray* document_types = [NSMutableArray array];

[tapted, 2014/04/17 04:37:50]

I think +[.. array] is only defined on NSArray.. Maybe [NSMutableArray
arrayWithCapacity:file_handlers_.size()]; More below

[jackhou1, 2014/04/22 04:40:19]

Done.

+
+  for (unsigned int i = 0; i < file_handlers_info.handlers->size(); ++i) {

[tapted, 2014/04/17 04:37:50]

vector::const_iterator?

[jackhou1, 2014/04/22 04:40:19]

Done.

+    const extensions::FileHandlerInfo& info =
+        file_handlers_info.handlers->at(i);
+
+    NSMutableArray* file_extensions = [NSMutableArray array];
+    for (std::set<std::string>::iterator it = info.extensions.begin();
+         it != info.extensions.end(); ++it) {
+      [file_extensions addObject:base::SysUTF8ToNSString(*it)];
+    }
+
+    NSMutableArray* mime_types = [NSMutableArray array];
+    for (std::set<std::string>::iterator it = info.types.begin();
+         it != info.types.end(); ++it) {
+      [mime_types addObject:base::SysUTF8ToNSString(*it)];
+    }
+
+    [document_types addObject:@{
+      // TODO(jackhou): Add the type name and and icon file once the manifest

[tapted, 2014/04/17 04:37:50]

nit: This.. probably needs more indent because it's inside [] function
arguments.

Maybe nicer to do 

NSDictionary* type_dictionary = @{
  foo : bar,
  baz : x
};
[document_types addObject:type_dictionary];

[jackhou1, 2014/04/22 04:40:19]

Done.

+      // supports these.
+      // app_mode::kCFBundleTypeNameKey : ,
+      // app_mode::kCFBundleTypeIconFileKey : ,
+      app_mode::kCFBundleTypeExtensionsKey : file_extensions,
+      app_mode::kCFBundleTypeMIMETypesKey : mime_types,
+      app_mode::kCFBundleTypeRoleKey : app_mode::kBundleTypeRoleViewer,

[tapted, 2014/04/17 04:37:50]

nit: not sure if style guide encourages a trailing comma...

[jackhou1, 2014/04/22 04:40:19]

Checked style guide. It's not explicit, but all examples lack trailing comma.

+    }];
+  }
+
+  [plist setObject:document_types
+            forKey:app_mode::kCFBundleDocumentTypesKey];
+}
+
 bool WebAppShortcutCreator::UpdatePlist(const base::FilePath& app_path) const {
   NSString* extension_id = base::SysUTF8ToNSString(info_.extension_id);
   NSString* extension_title = base::SysUTF16ToNSString(info_.title);
   NSString* extension_url = base::SysUTF8ToNSString(info_.url.spec());
   NSString* chrome_bundle_id =
       base::SysUTF8ToNSString(base::mac::BaseBundleID());
   NSDictionary* replacement_dict =
       [NSDictionary dictionaryWithObjectsAndKeys:
           extension_id, app_mode::kShortcutIdPlaceholder,
           extension_title, app_mode::kShortcutNamePlaceholder,
@@ skipping 34 matching lines @@
   if (info_.extension_id == app_mode::kAppListModeId) {
     // Prevent the app list from bouncing in the dock, and getting a run light.
     [plist setObject:[NSNumber numberWithBool:YES]
               forKey:kLSUIElement];
   }
 
   base::FilePath app_name = app_path.BaseName().RemoveExtension();
   [plist setObject:base::mac::FilePathToNSString(app_name)
             forKey:base::mac::CFToNSCast(kCFBundleNameKey)];
 
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kEnableAppsFileAssociations)) {
+    UpdateFileTypes(plist, file_handlers_info_);
+  }
+
   return [plist writeToFile:plist_path
                  atomically:YES];
 }
 
 bool WebAppShortcutCreator::UpdateDisplayName(
     const base::FilePath& app_path) const {
   // OSX searches for the best language in the order of preferred languages.
   // Since we only have one localization directory, it will choose this one.
   base::FilePath localized_dir = GetResourcesPath(app_path).Append("en.lproj");
   if (!base::CreateDirectory(localized_dir))
@@ skipping 97 matching lines @@
   if (app_path.empty())
     return;
 
   [[NSWorkspace sharedWorkspace]
                     selectFile:base::mac::FilePathToNSString(app_path)
       inFileViewerRootedAtPath:nil];
 }
 
 base::FilePath GetAppInstallPath(
     const ShellIntegration::ShortcutInfo& shortcut_info) {
-  WebAppShortcutCreator shortcut_creator(base::FilePath(), shortcut_info);
+  WebAppShortcutCreator shortcut_creator(
+      base::FilePath(), shortcut_info, extensions::FileHandlersInfo(NULL));
   return shortcut_creator.GetApplicationsShortcutPath();
 }
 
 void MaybeLaunchShortcut(const ShellIntegration::ShortcutInfo& shortcut_info) {
   if (!apps::IsAppShimsEnabled())
     return;
 
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(&LaunchShimOnFileThread, shortcut_info));
 }
 
 namespace internals {
 
 bool CreatePlatformShortcuts(
     const base::FilePath& app_data_path,
     const ShellIntegration::ShortcutInfo& shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info,
     const ShellIntegration::ShortcutLocations& creation_locations,
     ShortcutCreationReason creation_reason) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
-  WebAppShortcutCreator shortcut_creator(app_data_path, shortcut_info);
+  WebAppShortcutCreator shortcut_creator(
+      app_data_path, shortcut_info, file_handlers_info);
   return shortcut_creator.CreateShortcuts(creation_reason, creation_locations);
 }
 
 void DeletePlatformShortcuts(
     const base::FilePath& app_data_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
-  WebAppShortcutCreator shortcut_creator(app_data_path, shortcut_info);
+  WebAppShortcutCreator shortcut_creator(
+      app_data_path, shortcut_info, extensions::FileHandlersInfo(NULL));
   shortcut_creator.DeleteShortcuts();
 }
 
 void UpdatePlatformShortcuts(
     const base::FilePath& app_data_path,
     const base::string16& old_app_title,
     const ShellIntegration::ShortcutInfo& shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
-  WebAppShortcutCreator shortcut_creator(app_data_path, shortcut_info);
+  WebAppShortcutCreator shortcut_creator(
+      app_data_path, shortcut_info, file_handlers_info);
   shortcut_creator.UpdateShortcuts();
 }
 
 void DeleteAllShortcutsForProfile(const base::FilePath& profile_path) {
   const std::string profile_base_name = profile_path.BaseName().value();
   std::vector<base::FilePath> bundles = GetAllAppBundlesInPath(
       profile_path.Append(chrome::kWebAppDirname), profile_base_name);
 
   for (std::vector<base::FilePath>::const_iterator it = bundles.begin();
        it != bundles.end(); ++it) {
     ShellIntegration::ShortcutInfo shortcut_info =
         BuildShortcutInfoFromBundle(*it);
-    WebAppShortcutCreator shortcut_creator(it->DirName(), shortcut_info);
+    WebAppShortcutCreator shortcut_creator(
+        it->DirName(), shortcut_info, extensions::FileHandlersInfo(NULL));
     shortcut_creator.DeleteShortcuts();
   }
 }
 
 }  // namespace internals
 
 }  // namespace web_app