Issue 6480070: Merge revisions 6611, 6795, 6797 to the 3.0 branch...

Issue 6480070: Merge revisions 6611, 6795, 6797 to the 3.0 branch... (Closed)

Created:
9 years, 10 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse, Kevin Millikin (Chromium), Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/3.0/

Visibility:
Public.

Description

Merge revisions 6611, 6795, 6797 to the 3.0 branch I added 6611 to this patch since it makes the merge a much cleaner. I can make another patch only merging 6795+6797, but this will include a bunch of hand merged stuff that I would love to avoid giving our test coverage for the 3.0 branch. Committed: http://code.google.com/p/v8/source/detail?r=6804

Patch Set 1 #

Total comments: 4

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+163 lines, -104 lines)			Patch
M	src/arm/deoptimizer-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/assembler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/disassembler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/deoptimizer-ia32.cc	View	2 chunks	+50 lines, -67 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	6 chunks	+25 lines, -5 lines	4 comments	Download
M	src/objects.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/safepoint-table.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/deoptimizer-x64.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-1156.js	View	1 chunk	+49 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

Could you get rid of the debug printing? Is that on bleeding_edge as well? Other ...

9 years, 10 months ago (2011-02-16 07:26:12 UTC) #3

Rico

9 years, 10 months ago (2011-02-16 07:31:13 UTC) #4

Nice catch, no they are not on bleeding_edge (debugging for finding the cause
for the assertion bug fixed in bleeding edge revision 6797) - sorry

http://codereview.chromium.org/6480070/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/6480070/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:57:
PrintF("--------------------GEEEEEEE-------------------\n");
On 2011/02/16 07:26:12, Mads Ager wrote:
> Remove please.

Done.

http://codereview.chromium.org/6480070/diff/1/src/ia32/lithium-codegen-ia32.c...
src/ia32/lithium-codegen-ia32.cc:59:
PrintF("--------------------FILLING-------------------\n");
On 2011/02/16 07:26:12, Mads Ager wrote:
> Remove please.

Done.

Expand Messages | Collapse Messages