chrome/browser/resources/options/options.js - Issue 6480039: chrome://settings - Provide method for pages to prevent themselves being shown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/options.js

Issue 6480039: chrome://settings - Provide method for pages to prevent themselves being shown. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment update Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/alert_overlay.js ('K') | « chrome/browser/resources/options/browser_options.js ('k') | chrome/browser/resources/options/options_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/options.js

diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js

index dfae2b3df36d32c1f6d4e10e007b56c7c78f2dd5..dc697591f864dcc1e4d543e08a89546cb46d86ec 100644

--- a/chrome/browser/resources/options/options.js

+++ b/chrome/browser/resources/options/options.js

@@ -161,16 +161,11 @@ function load() {

OptionsPage.initialize();

var path = document.location.pathname;

- // TODO(estade): remove this explicit hash handling. Pages should check for

- // location.hash in didShowPage.

- var hash = document.location.hash;

if (path.length > 1) {

var pageName = path.slice(1);

// Show page, but don't update history (there's already an entry for it).

OptionsPage.showPageByName(pageName, false);

- if (hash.length > 1)

- OptionsPage.handleHashForPage(pageName, hash.slice(1));

} else {

OptionsPage.showDefaultPage();

}