Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 6480039: chrome://settings - Provide method for pages to prevent themselves being shown. (Closed)

Created:
9 years, 10 months ago by Evan Stade
Modified:
6 years, 2 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

chrome://settings - Provide method for pages to prevent themselves being shown. use this method in: - alert overlay - add startup page overlay - password manager overlay these are the places I determined should be sometimes disabled when I did a sweep of the code, but I'm probably missing something. BUG=none TEST=chrome://settings/alertOverlay should show the basic browser page Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74878

Patch Set 1 #

Patch Set 2 : other cases #

Total comments: 10

Patch Set 3 : respond to comments #

Patch Set 4 : . #

Patch Set 5 : fix logic #

Patch Set 6 : comment update #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -33 lines) Patch
M chrome/browser/resources/options/add_startup_page_overlay.js View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/alert_overlay.js View 1 2 3 chunks +26 lines, -3 lines 2 comments Download
M chrome/browser/resources/options/browser_options.js View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/options_page.js View 1 2 3 4 chunks +27 lines, -21 lines 0 comments Download
M chrome/browser/resources/options/password_manager.js View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/personal_options.js View 1 2 3 4 5 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
Evan Stade
9 years, 10 months ago (2011-02-12 00:28:36 UTC) #1
stuartmorgan
http://codereview.chromium.org/6480039/diff/2001/chrome/browser/resources/options/add_startup_page_overlay.js File chrome/browser/resources/options/add_startup_page_overlay.js (right): http://codereview.chromium.org/6480039/diff/2001/chrome/browser/resources/options/add_startup_page_overlay.js#newcode117 chrome/browser/resources/options/add_startup_page_overlay.js:117: return !$('startupAddButton').disabled; I'm not wild on using UI state ...
9 years, 10 months ago (2011-02-12 01:09:05 UTC) #2
Evan Stade
http://codereview.chromium.org/6480039/diff/2001/chrome/browser/resources/options/add_startup_page_overlay.js File chrome/browser/resources/options/add_startup_page_overlay.js (right): http://codereview.chromium.org/6480039/diff/2001/chrome/browser/resources/options/add_startup_page_overlay.js#newcode117 chrome/browser/resources/options/add_startup_page_overlay.js:117: return !$('startupAddButton').disabled; On 2011/02/12 01:09:06, stuartmorgan wrote: > I'm ...
9 years, 10 months ago (2011-02-12 03:06:42 UTC) #3
stuartmorgan
LGTM
9 years, 10 months ago (2011-02-14 18:50:16 UTC) #4
stuartmorgan
On 2011/02/14 18:50:16, stuartmorgan wrote: > LGTM Whoops, wrong CL. I'm just starting on this ...
9 years, 10 months ago (2011-02-14 18:54:58 UTC) #5
stuartmorgan
LGTM (for realz this time)
9 years, 10 months ago (2011-02-14 18:59:35 UTC) #6
Vitaly Pavlenko
https://codereview.chromium.org/6480039/diff/2004/chrome/browser/resources/options/alert_overlay.js File chrome/browser/resources/options/alert_overlay.js (right): https://codereview.chromium.org/6480039/diff/2004/chrome/browser/resources/options/alert_overlay.js#newcode75 chrome/browser/resources/options/alert_overlay.js:75: canShow_ = false; This should be this.canShow_ = false; ...
6 years, 2 months ago (2014-10-01 23:29:53 UTC) #8
Evan Stade
6 years, 2 months ago (2014-10-13 16:21:55 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/6480039/diff/2004/chrome/browser/resources/op...
File chrome/browser/resources/options/alert_overlay.js (right):

https://codereview.chromium.org/6480039/diff/2004/chrome/browser/resources/op...
chrome/browser/resources/options/alert_overlay.js:75: canShow_ = false;
On 2014/10/01 23:29:53, Vitaly Pavlenko wrote:
> This should be 
> 
> this.canShow_ = false;
> 
> right?

yes

Powered by Google App Engine
This is Rietveld 408576698