Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: crash_reporter.cc

Issue 6480009: crash-reporter: when exe symlink read fails send diags and still ignore chrome crashes (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/crash-reporter.git@master
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | user_collector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crash_reporter.cc
diff --git a/crash_reporter.cc b/crash_reporter.cc
index ffe6cdfed17e999ff005fb0efd1b8795af88f418..ab4c5ba3bfe6a8bd590346260ba0c401021743ea 100644
--- a/crash_reporter.cc
+++ b/crash_reporter.cc
@@ -148,10 +148,13 @@ static int HandleUserCrash(UserCollector *user_collector) {
return 0;
}
+ // Accumulate logs to help in diagnosing failures during user collection.
+ s_system_log.set_accumulating(true);
// Handle the crash, get the name of the process from procfs.
- if (!user_collector->HandleCrash(FLAGS_user, NULL)) {
+ bool handled = user_collector->HandleCrash(FLAGS_user, NULL);
+ s_system_log.set_accumulating(false);
+ if (!handled)
return 1;
- }
return 0;
}
« no previous file with comments | « no previous file | user_collector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698