Chromium Code Reviews Chromium Code Reviews
Issue 647953004:
Don't delete objects from the floating list during layout (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/http/tests/shapes/crash-image-changed-during-layout.html |
| diff --git a/LayoutTests/http/tests/shapes/crash-image-changed-during-layout.html b/LayoutTests/http/tests/shapes/crash-image-changed-during-layout.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..0fa8ac9e1874550739c93fc17298f548b7fcd07b |
| --- /dev/null |
| +++ b/LayoutTests/http/tests/shapes/crash-image-changed-during-layout.html |
| @@ -0,0 +1,32 @@ |
| +<!doctype HTML> |
| +crbug.com/423891: Crashes if we remove a float from the |
| +floating objects list during layout. |
| +This test should not crash. |
| +<style> |
| +* { line-height: 30rem; shape-outside: url("data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg'> fill='blue'/></svg>");} |
|
Julien - ping for review
2014/10/21 19:15:29
Really not a huge fan of using the universal selec
|
| +</style> |
| +<style> |
|
Julien - ping for review
2014/10/21 19:15:29
And we also need the 2 <style>?
|
| +.c29 { |
| + src: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAkAAAAJCAIAAABv85FHAAAABnRSTlMA/wAAAACkwsAdAAAAIUlEQVR4nGP4z8CAC+GUIEXuABhgkTuABEiRw2cmae4EAH05X7xDolNRAAAAAElFTkSuQmCC") format(attr(r)); |
| + float: left; |
| + min-width: 30in; |
| + border-top: solid rgba(185, 191, 175, 0.254400) 66em; |
| +} |
| +</style> |
| +<script> |
| +if (window.testRunner) |
| + testRunner.dumpAsText(); |
| + |
| +var docElement = document.body; |
| +function init() { |
| + fespotlight = document.createElementNS("http://www.w3.org/1999/xhtml", "fespotlight"); |
| + fespotlight.setAttribute("class", "c29"); |
| + docElement.appendChild(fespotlight); |
| + picture = document.createElementNS("http://www.w3.org/1999/xhtml", "picture"); |
| + picture.setAttribute("class", "c29"); |
| + docElement.appendChild(picture); |
| + text = document.createTextNode("This test should not crash. This test should not crash."); |
|
Julien - ping for review
2014/10/21 19:15:29
That's a lot of "This test should not crash." (3 t
|
| + docElement.appendChild(text); |
| +} |
| +document.addEventListener("DOMContentLoaded", init, false); |
| +</script> |
