Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 647923002: Allow the number of undecryptable QUIC packets buffered before the (Closed)

Created:
6 years, 2 months ago by ramant (doing other things)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@merge_76636673
Project:
chromium
Visibility:
Public.

Description

Allow the number of undecryptable QUIC packets buffered before the CHLO/SHLO to be configured in QuicConfig. Merge internal change: 76707156 On chromium side: set max undecryptable packets to the initial congestion window size in QuicStreamFactory. R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Set max undecryptable packets to the initial congestion window size. #

Patch Set 3 : set max_undecryptable_packets_ to 100 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -12 lines) Patch
M net/quic/quic_config.h View 2 chunks +10 lines, -0 lines 0 comments Download
M net/quic/quic_config.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M net/quic/quic_connection_test.cc View 2 chunks +44 lines, -7 lines 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
6 years, 2 months ago (2014-10-10 22:41:18 UTC) #1
Ryan Hamilton
IIRC, I think we also want to make a chrome-side change to set the max ...
6 years, 2 months ago (2014-10-10 22:51:11 UTC) #3
ramant (doing other things)
On 2014/10/10 22:51:11, Ryan Hamilton wrote: > IIRC, I think we also want to make ...
6 years, 2 months ago (2014-10-10 23:19:52 UTC) #4
ramant (doing other things)
On 2014/10/10 23:19:52, ramant wrote: > On 2014/10/10 22:51:11, Ryan Hamilton wrote: > > IIRC, ...
6 years, 2 months ago (2014-10-10 23:45:16 UTC) #6
Ian Swett
On 2014/10/10 23:45:16, ramant wrote: > On 2014/10/10 23:19:52, ramant wrote: > > On 2014/10/10 ...
6 years, 2 months ago (2014-10-11 03:47:44 UTC) #7
ramant (doing other things)
6 years, 2 months ago (2014-10-13 17:43:35 UTC) #8
On 2014/10/11 03:47:44, Ian Swett wrote:
> On 2014/10/10 23:45:16, ramant wrote:
> > On 2014/10/10 23:19:52, ramant wrote:
> > > On 2014/10/10 22:51:11, Ryan Hamilton wrote:
> > > > IIRC, I think we also want to make a chrome-side change to set the max
> > > > undecryptable packets to something like the initial congestion window
size
> > in
> > > > the QuicConfig. (I think this logic is in the QuicStreamFactory). Your
> merge
> > > > LGTM, but we should also add change the value chrome uses.
> > > 
> > > Thanks very much Ryan. Updated the QuicStreamFactory's QuicConfig's
> > > max_undecryptable_packets.
> > 
> > Hi Ryan,
> >   Set the max_undecryptable_packets_ to either 32 (https) or 20 (http) same
as
> > initial congestion window size. I hope I got it right. PTAL.
> > 
> > thanks
> > raman
> 
> In case we ever want to increase initial CWND for some connections, I would
> suggest a larger value, such as 100, unless there is a concern that would
cause
> problems for Chrome.

Done.

thanks Ian,
raman

Powered by Google App Engine
This is Rietveld 408576698