Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1989)

Unified Diff: chrome/browser/dom_ui/bug_report_ui.cc

Issue 6479007: Attempt 3 at: Splits ChromeURLDataManager into 2 chunks:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/dom_ui/bug_report_ui.cc
===================================================================
--- chrome/browser/dom_ui/bug_report_ui.cc (revision 74394)
+++ chrome/browser/dom_ui/bug_report_ui.cc (working copy)
@@ -21,6 +21,7 @@
#include "chrome/browser/bug_report_data.h"
#include "chrome/browser/bug_report_util.h"
#include "chrome/browser/dom_ui/web_ui_screenshot_source.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/tab_contents/tab_contents.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
@@ -432,9 +433,9 @@
//
////////////////////////////////////////////////////////////////////////////////
BugReportHandler::BugReportHandler(TabContents* tab)
- : tab_(tab)
- , screenshot_source_(NULL)
- , bug_report_(NULL)
+ : tab_(tab),
+ screenshot_source_(NULL),
+ bug_report_(NULL)
#if defined(OS_CHROMEOS)
, syslogs_handle_(0)
#endif
@@ -454,12 +455,8 @@
// Re-create our screenshots data source (this clobbers the last source)
// setting the screenshot to NULL, effectively disabling the source
// TODO(rkc): Once there is a method to 'remove' a source, change this code
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(
- ChromeURLDataManager::GetInstance(),
- &ChromeURLDataManager::AddDataSource,
- make_scoped_refptr(new WebUIScreenshotSource(NULL))));
+ tab_->profile()->GetChromeURLDataManager()->AddDataSource(
+ new WebUIScreenshotSource(NULL));
// clobber last screenshot
if (browser::last_screenshot_png)
@@ -473,12 +470,7 @@
browser::last_screenshot_png);
// Add the source to the data manager.
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(
- ChromeURLDataManager::GetInstance(),
- &ChromeURLDataManager::AddDataSource,
- make_scoped_refptr(screenshot_source_)));
+ tab_->profile()->GetChromeURLDataManager()->AddDataSource(screenshot_source_);
}
WebUIMessageHandler* BugReportHandler::Attach(DOMUI* dom_ui) {
@@ -749,10 +741,5 @@
BugReportUIHTMLSource* html_source =
new BugReportUIHTMLSource(handler->Init());
// Set up the chrome://bugreport/ source.
- BrowserThread::PostTask(
- BrowserThread::IO, FROM_HERE,
- NewRunnableMethod(
- ChromeURLDataManager::GetInstance(),
- &ChromeURLDataManager::AddDataSource,
- make_scoped_refptr(html_source)));
+ tab->profile()->GetChromeURLDataManager()->AddDataSource(html_source);
}

Powered by Google App Engine
This is Rietveld 408576698