Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5088)

Unified Diff: chrome/browser/browser_about_handler_unittest.cc

Issue 6479007: Attempt 3 at: Splits ChromeURLDataManager into 2 chunks:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_about_handler_unittest.cc
===================================================================
--- chrome/browser/browser_about_handler_unittest.cc (revision 74394)
+++ chrome/browser/browser_about_handler_unittest.cc (working copy)
@@ -5,8 +5,10 @@
#include "base/basictypes.h"
#include "base/scoped_ptr.h"
#include "chrome/browser/browser_about_handler.h"
+#include "chrome/browser/browser_thread.h"
#include "chrome/common/about_handler.h"
#include "chrome/common/url_constants.h"
+#include "chrome/test/testing_profile.h"
#include "googleurl/src/gurl.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -96,13 +98,16 @@
true
},
};
+ MessageLoopForUI message_loop;
+ BrowserThread ui_thread(BrowserThread::UI, &message_loop);
+ TestingProfile profile;
for (size_t i = 0; i < ARRAYSIZE_UNSAFE(test_data); ++i) {
GURL url(test_data[i].test_url);
EXPECT_EQ(test_data[i].about_handled,
chrome_about_handler::WillHandle(url));
EXPECT_EQ(test_data[i].browser_handled,
- WillHandleBrowserAboutURL(&url, NULL));
+ WillHandleBrowserAboutURL(&url, &profile));
EXPECT_EQ(test_data[i].result_url, url);
}

Powered by Google App Engine
This is Rietveld 408576698