Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 6479003: Move site_backchannel and site_tpm module into client/cros dir. (Closed)

Created:
9 years, 10 months ago by ericli
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Move site_backchannel and site_tpm module into client/cros dir. And also update all import reference from anywhere else. Change-Id: Ic32c300f25716698ed346e82b439b2c1ee0c3c9d BUG=None. TEST=I will defer the test of this change. The change itself is trivia but setup a test env is overwhelming. I will leave the change to be tested in lab and I believe this is safe. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b910a9d

Patch Set 1 #

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
A + client/cros/backchannel.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + client/cros/tpm.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M client/site_tests/hardware_TPM/hardware_TPM.py View 2 chunks +4 lines, -2 lines 0 comments Download
M client/site_tests/network_3GDormancyDance/network_3GDormancyDance.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/network_3GFailedConnect/network_3GFailedConnect.py View 3 chunks +4 lines, -3 lines 0 comments Download
M client/site_tests/network_3GSafetyDance/network_3GSafetyDance.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/network_3GSmokeTest/network_3GSmokeTest.py View 3 chunks +4 lines, -3 lines 0 comments Download
M client/site_tests/network_3GStressEnable/network_3GStressEnable.py View 1 chunk +1 line, -1 line 0 comments Download
M client/site_tests/power_LoadTest/power_LoadTest.py View 1 4 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ericli
9 years, 10 months ago (2011-02-10 00:40:38 UTC) #1
DaleCurtis
LGTM, at least start a power_LoadTest though. I assume you've grepped the rest of the ...
9 years, 10 months ago (2011-02-11 04:01:26 UTC) #2
ericli
Seeking a LTGM from Luigi as well. Thanks.
9 years, 10 months ago (2011-02-11 18:15:09 UTC) #3
Luigi Semenzato
LGTM but hardware_TPM is only run manually, so I don't think this will get tested. ...
9 years, 10 months ago (2011-02-11 19:30:38 UTC) #4
ericli
9 years, 10 months ago (2011-02-11 19:34:00 UTC) #5
Thanks. But I will leave the actual fix of TPM test to you.

On Fri, Feb 11, 2011 at 11:30 AM, <semenzato@chromium.org> wrote:

> LGTM but hardware_TPM is only run manually, so I don't think this will get
> tested.  In fact it's possible that it's already broken.
>
>
>
> On 2011/02/11 18:15:09, ericli wrote:
>
>> Seeking a LTGM from Luigi as well. Thanks.
>>
>
>
>
> http://codereview.chromium.org/6479003/
>



-- 
Eric Li
李咏竹
Google Kirkland

Powered by Google App Engine
This is Rietveld 408576698