git cl format the final third of the net/base directory

git cl format the final third of the net/base directory

This is the first step in formatting the net/ directory.

How this CL was made: find . | egrep '(\.c|\.h|\.m|\.mm|\.cc|\.cp|\.cpp|\.c++|\.cxx|\.hpp|\.pro|\.protodevel|\.js)$' | tail -n 70 | xargs clang-format --style=chromium -i

net/base/ CLs:
https://codereview.chromium.org/642403002/
https://codereview.chromium.org/649763002/
* https://codereview.chromium.org/647883002/


BUG=422332

[jkarlin, 2014-10-10 19:35:12]

jkarlin@chromium.org changed reviewers:
+ mef@chromium.org

[jkarlin, 2014-10-10 19:35:25]

On 2014/10/10 19:35:12, jkarlin wrote:
> mailto:jkarlin@chromium.org changed reviewers:
> + mailto:mef@chromium.org

Thanks!

[mef, 2014-10-10 20:38:17]

Looks decent to me, but I'm pretty tolerant reviewer. I'd rope in pauljensen@
and mmenke@ to get more critical opinion.

General themes that made me unhappy:

- For loops split into 3 lines.
- Member initializers pulled into one line.
- Random struct initalizer formatting.
- Misunderstanding of lines ending with "|".

https://codereview.chromium.org/647883002/diff/1/net/base/address_list.cc
File net/base/address_list.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/address_list.cc#new...
net/base/address_list.cc:23: it != address_list->end();
I'm not sure about 3-line split in for loop.

https://codereview.chromium.org/647883002/diff/1/net/base/address_list_unitte...
File net/base/address_list_unittest.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/address_list_unitte...
net/base/address_list_unittest.cc:99: "127.0.0.1",
this formatting looks ok, but not quite great.

https://codereview.chromium.org/647883002/diff/1/net/base/auth.cc
File net/base/auth.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/auth.cc#newcode33
net/base/auth.cc:33: : username_(username), password_(password) {
I've heard claims that those should be on separate lines.

https://codereview.chromium.org/647883002/diff/1/net/base/data_url.cc
File net/base/data_url.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/data_url.cc#newcode103
net/base/data_url.cc:103: UnescapeRule::SPACES |
this is definitely wrong.

https://codereview.chromium.org/647883002/diff/1/net/base/filename_util_unsaf...
File net/base/filename_util_unsafe.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/filename_util_unsaf...
net/base/filename_util_unsafe.cc:17: const base::FilePath::CharType
illegal_characters[] = FILE_PATH_LITERAL(
this is ugly.

https://codereview.chromium.org/647883002/diff/1/net/base/host_mapping_rules.cc
File net/base/host_mapping_rules.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/host_mapping_rules....
net/base/host_mapping_rules.cc:46: it != map_rules_.end();
3 lines in for.

https://codereview.chromium.org/647883002/diff/1/net/base/host_port_pair_unit...
File net/base/host_port_pair_unittest.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/host_port_pair_unit...
net/base/host_port_pair_unittest.cc:23: {"www.google.com", 80,
"www.google.com:80", "www.google.com"},
questionable alignment.

https://codereview.chromium.org/647883002/diff/1/net/base/ip_endpoint_unittes...
File net/base/ip_endpoint_unittest.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/ip_endpoint_unittes...
net/base/ip_endpoint_unittest.cc:27: {"127.0.00.1", "127.0.0.1", false},
it seems that those always have 5 leading spaces.

https://codereview.chromium.org/647883002/diff/1/net/base/load_timing_info.cc
File net/base/load_timing_info.cc (right):

https://codereview.chromium.org/647883002/diff/1/net/base/load_timing_info.cc...
net/base/load_timing_info.cc:14: LoadTimingInfo::ConnectTiming::~ConnectTiming()
{
weird diff, but looks ok.

https://codereview.chromium.org/647883002/diff/1/net/base/net_log.h
File net/base/net_log.h (right):

https://codereview.chromium.org/647883002/diff/1/net/base/net_log.h#newcode393
net/base/net_log.h:393: : source_(source), net_log_(net_log) {}
Hmm, in many cases it seems to split {} into 2 lines, but here it actually
combined them into 1.

https://codereview.chromium.org/647883002/diff/1/net/base/network_change_noti...
File net/base/network_change_notifier.h (right):

https://codereview.chromium.org/647883002/diff/1/net/base/network_change_noti...
net/base/network_change_notifier.h:294: NetworkChangeCalculatorParams());
not sure about motivation of this alignment.

https://codereview.chromium.org/647883002/diff/1/net/base/nss_memio.c
File net/base/nss_memio.c (right):

https://codereview.chromium.org/647883002/diff/1/net/base/nss_memio.c#newcode31
net/base/nss_memio.c:31: /* TODO(port): error handling is pessimistic right now.
not sure that this comment should align with those above.

https://codereview.chromium.org/647883002/diff/1/net/base/nss_memio.c#newcode127
net/base/nss_memio.c:127: /* Handle part before wrap */
I think NSS has/had formatting different from Chromium. Not sure what is the
right thing here.

[jkarlin, 2014-10-31 15:55:43]

My plan is to wait for the next clang-format roll, then I'll rebase, make
reasonable fixes by hand, reformat, and ask you to take another look.

[jkarlin, 2014-12-18 18:28:38]

Closing as this is now out of date and we don't have immediate plans to format
all of net/