Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 647863002: Track if all stages modulate inputColor in computeInvariantOutput (Closed)

Created:
6 years, 2 months ago by egdaniel
Modified:
6 years, 2 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@addSomeFunctions
Project:
skia
Visibility:
Public.

Description

Track if all stages modulate inputColor in computeInvariantOutput BUG=skia: Committed: https://skia.googlesource.com/skia/+/ab84fae29fdee95987b10c00ff34957476a66263

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : update #

Total comments: 4

Patch Set 4 : Review changes #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M include/gpu/GrProcessor.h View 1 2 3 5 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
6 years, 2 months ago (2014-10-13 19:19:08 UTC) #2
bsalomon
https://codereview.chromium.org/647863002/diff/140001/include/gpu/GrProcessor.h File include/gpu/GrProcessor.h (right): https://codereview.chromium.org/647863002/diff/140001/include/gpu/GrProcessor.h#newcode42 include/gpu/GrProcessor.h:42: fInputIsOnlyModulated(true) {} I seems like we should use multiply ...
6 years, 2 months ago (2014-10-13 19:52:49 UTC) #3
egdaniel
https://codereview.chromium.org/647863002/diff/140001/include/gpu/GrProcessor.h File include/gpu/GrProcessor.h (right): https://codereview.chromium.org/647863002/diff/140001/include/gpu/GrProcessor.h#newcode42 include/gpu/GrProcessor.h:42: fInputIsOnlyModulated(true) {} On 2014/10/13 19:52:49, bsalomon wrote: > I ...
6 years, 2 months ago (2014-10-13 20:26:47 UTC) #4
bsalomon
lgtm
6 years, 2 months ago (2014-10-13 20:48:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/647863002/250001
6 years, 2 months ago (2014-10-14 13:41:48 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 13:48:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 (id:250001) as ab84fae29fdee95987b10c00ff34957476a66263

Powered by Google App Engine
This is Rietveld 408576698