Set Service property ManagedCredentials for managed networks.

Set Service property ManagedCredentials for managed networks.

This allows autoconnect to policy pushed networks without the user having to manually trigger a successful connect once.

BUG=424036
Committed: https://crrev.com/1ff2e0f5b43de3ad05083cc28246317a514c1f63
Cr-Commit-Position: refs/heads/master@{#302433}

[pneubeck (no reviews), 2014-10-30 13:32:55]

Patchset #1 (id:1) has been deleted

[pneubeck (no reviews), 2014-10-30 13:34:34]

Patchset #1 (id:20001) has been deleted

[pneubeck (no reviews), 2014-10-30 13:36:50]

pneubeck@chromium.org changed reviewers:
+ pstew@chromium.org

[pneubeck (no reviews), 2014-10-30 13:36:50]

ptal

[pneubeck (no reviews), 2014-10-30 13:38:44]

Patchset #1 (id:40001) has been deleted

[pneubeck (no reviews), 2014-10-30 15:01:05]

Patchset #1 (id:60001) has been deleted

[pneubeck (no reviews), 2014-10-30 15:01:10]

Patchset #1 (id:80001) has been deleted

[Paul Stewart, 2014-10-30 15:32:42]

LGTM.  Still pinging on https://chromium-review.googlesource.com/#/c/223653

https://codereview.chromium.org/647783005/diff/100001/chromeos/network/policy...
File chromeos/network/policy_util.cc (right):

https://codereview.chromium.org/647783005/diff/100001/chromeos/network/policy...
chromeos/network/policy_util.cc:366: shill::kManagedCredentialsProperty, true);
It's okay to do this even if auto-connect is unset / set false.  The two are
orthogonal.

[pneubeck (no reviews), 2014-10-30 15:46:40]

https://codereview.chromium.org/647783005/diff/100001/chromeos/network/policy...
File chromeos/network/policy_util.cc (right):

https://codereview.chromium.org/647783005/diff/100001/chromeos/network/policy...
chromeos/network/policy_util.cc:366: shill::kManagedCredentialsProperty, true);
On 2014/10/30 15:32:42, Paul Stewart wrote:
> It's okay to do this even if auto-connect is unset / set false.  The two are
> orthogonal.

The question is however, what behavior we want to trigger if policy didn't set
autoconnect and the user is setting autoconnect=true.
The current implementation should be the conservative choice in this case.

[Paul Stewart, 2014-10-30 15:55:05]

On 2014/10/30 15:46:40, pneubeck wrote:
>
https://codereview.chromium.org/647783005/diff/100001/chromeos/network/policy...
> File chromeos/network/policy_util.cc (right):
> 
>
https://codereview.chromium.org/647783005/diff/100001/chromeos/network/policy...
> chromeos/network/policy_util.cc:366: shill::kManagedCredentialsProperty,
true);
> On 2014/10/30 15:32:42, Paul Stewart wrote:
> > It's okay to do this even if auto-connect is unset / set false.  The two are
> > orthogonal.
> 
> The question is however, what behavior we want to trigger if policy didn't set
> autoconnect and the user is setting autoconnect=true.
> The current implementation should be the conservative choice in this case.

sgtm

[pneubeck (no reviews), 2014-11-03 10:10:31]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-11-03 10:11:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647783005/120001

[commit-bot: I haz the power, 2014-11-03 10:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-03 10:11:09]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[pneubeck (no reviews), 2014-11-03 10:21:28]

pneubeck@chromium.org changed reviewers:
+ bartfab@chromium.org

[pneubeck (no reviews), 2014-11-03 10:21:28]

@Bartosz, ptal

[pneubeck (no reviews), 2014-11-03 15:01:48]

pneubeck@chromium.org changed reviewers:
+ joaodasilva@chromium.org
- bartfab@chromium.org

[pneubeck (no reviews), 2014-11-03 15:01:49]

ptal

[Joao da Silva, 2014-11-03 15:07:21]

lgtm

[pneubeck (no reviews), 2014-11-03 15:07:49]

The CQ bit was checked by pneubeck@chromium.org

[commit-bot: I haz the power, 2014-11-03 15:08:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/647783005/120001

[bartfab (slow), 2014-11-03 15:30:21]

bartfab@chromium.org changed reviewers:
+ bartfab@chromium.org

[bartfab (slow), 2014-11-03 15:30:21]

lgtm

[commit-bot: I haz the power, 2014-11-03 16:10:03]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2014-11-03 16:10:47]

Patchset 2 (id:??) landed as
https://crrev.com/1ff2e0f5b43de3ad05083cc28246317a514c1f63
Cr-Commit-Position: refs/heads/master@{#302433}