Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 647773004: [turbofan] Skip bounds checks for positive indices only. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[turbofan] Skip bounds checks for positive indices only. TEST=unittests,mjsunit/asm/int32array-constant-key R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24716

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -28 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/asm/int32array-constant-key.js View 1 chunk +31 lines, -1 line 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +88 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-20 06:19:06 UTC) #2
Sven Panne
lgtm
6 years, 2 months ago (2014-10-20 06:20:36 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-20 06:25:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24716 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698